Skip to content

Commit 7f7edfa

Browse files
authored
Update based on latest settings and version (#39)
1 parent 3dcaa9a commit 7f7edfa

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.devcontainer/Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.195.0/containers/java/.devcontainer/base.Dockerfile
2-
# [Choice] Java version (use -bullseye variants on local arm64/Apple Silicon): 8, 11, 16, 8-bullseye, 11-bullseye, 16-bullseye, 8-buster, 11-buster, 16-buster
1+
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/main/containers/java/.devcontainer/base.Dockerfile
2+
# [Choice] Java version (use -bullseye variants on local arm64/Apple Silicon): 8, 11, 17, 8-bullseye, 11-bullseye, 17-bullseye, 8-buster, 11-buster, 17-buster
33
ARG VARIANT=11-bullseye
4-
FROM mcr.microsoft.com/vscode/devcontainers/java:0-${VARIANT}
4+
FROM mcr.microsoft.com/vscode/devcontainers/java:${VARIANT}
55

66
# [Option] Install Maven
77
ARG INSTALL_MAVEN="false"
@@ -21,4 +21,4 @@ RUN if [ "${NODE_VERSION}" != "none" ]; then su vscode -c "umask 0002 && . /usr/
2121
# && apt-get -y install --no-install-recommends <your-package-list-here>
2222

2323
# [Optional] Uncomment this line to install global node packages.
24-
# RUN su vscode -c "source /usr/local/share/nvm/nvm.sh && npm install -g <your-package-here>" 2>&1
24+
# RUN su vscode -c "source /usr/local/share/nvm/nvm.sh && npm install -g <your-package-here>" 2>&1

.devcontainer/devcontainer.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
"vscode": {
2424
// Set *default* container specific settings.json values on container create.
2525
"settings": {
26-
"java.home": "/docker-java-home",
2726
"maven.executable.path": "/usr/local/sdkman/candidates/maven/current/bin/mvn"
2827
},
2928

0 commit comments

Comments
 (0)