Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for syntax highlighting support for named arguments in PHP 8 #183181

Closed
asispts opened this issue May 23, 2023 · 1 comment
Closed

Request for syntax highlighting support for named arguments in PHP 8 #183181

asispts opened this issue May 23, 2023 · 1 comment
Assignees
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@asispts
Copy link

asispts commented May 23, 2023

Please support syntax highlighting for named arguments in PHP 8. Currently, the feature/token is detected as constant.other.php, making it difficult to distinguish named arguments from constants.

Code to reproduce

<?php declare(strict_types=1);

#[Attribute(name:'attribute')]
function foobar()
{
    throw new RuntimeException(message:'Exception', code:1);
}
@alexr00
Copy link
Member

alexr00 commented May 23, 2023

The folks in https://github.com/KapitanOczywisty/language-php have recently taken on the task of maintaining the PHP syntax highlighting grammar that we use in VS Code 👏 I've moved your issue into that repo: KapitanOczywisty/language-php#7

@alexr00 alexr00 added grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream labels May 23, 2023
@alexr00 alexr00 closed this as completed May 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

4 participants