-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When changes are accepted/rejected the Uris are not notebook friendly #239555
Comments
@bpasero I'd like to get a more user friendly url displayed in the chat panel for changes to notebook cells. I'm not entirely sure whether making the change to the LabelService as in the PR is the right approach. Please advice on how we can improve the display format. |
Are these specific URIs for cells? Then why not register a handler for the formatting of these?
|
Yes Thanks I should have mentioned that I did look into that & unfortunately that formatter doesn't support setting prefixes to the Uri dynamically based on whether this is the first or second or third cell. & unfortunately that information isn't part of the Uri. The only way I can do this is to register a formatter just before i invoke I don't think thats right, after all I might as well manually add the suffix |
It smells like debt to me to encode notebook specific logic into a core service like labels, so I would not go down that path. Can you address this for now just in chat? |
Today
Its difficult to tell what cells were updated
Proposed
The text was updated successfully, but these errors were encountered: