Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal suggest: Widget should hide when going to new line #239694

Closed
Tyriar opened this issue Feb 5, 2025 · 7 comments · Fixed by #239800
Closed

Terminal suggest: Widget should hide when going to new line #239694

Tyriar opened this issue Feb 5, 2025 · 7 comments · Fixed by #239800
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest
Milestone
February 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 5, 2025 •
edited
Loading

Repro:

  1. Windows/pwsh (maybe required?)
  2. Type git commit -m "code, or something that shows the suggest widget at the end of the line
  3. Press enter to go to new line, 🐛 suggest widget sticks around

Image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels Feb 5, 2025
@Tyriar Tyriar added this to the February 2025 milestone Feb 5, 2025
@Tyriar
Copy link
Member Author

Tyriar commented Feb 5, 2025

Looks to be prompt input model related:

Image

@meganrogge
Copy link
Contributor

I can reproduce on mac

@Tyriar
Copy link
Member Author

Tyriar commented Feb 6, 2025

Adding an ending quote will add the new line to promptinputmodel

Image

Image

@Tyriar Tyriar assigned Tyriar and unassigned meganrogge Feb 6, 2025
@Tyriar
Copy link
Member Author

Tyriar commented Feb 6, 2025

The repro for this isn't as straightforward as I thought, saw it today earlier but struggling to repro again

@Tyriar
Copy link
Member Author

Tyriar commented Feb 6, 2025

The viewport must be full to reproduce:

Image

@Tyriar
Copy link
Member Author

Tyriar commented Feb 6, 2025

Better repro:

  1. Open terminal
  2. Run ls to fill viewport
  3. Paste git commit -m "a
  4. Type e (or a char from some relative file/folder)
  5. Enter, 🐛

@Tyriar
Copy link
Member Author

Tyriar commented Feb 6, 2025

It's happening because the continuation prompt may be trimmed when we compare:

Image

Tyriar added a commit that referenced this issue Feb 6, 2025
@Tyriar
Be less strict when checking line continuation
0b78695 
Fixes #239694
@Tyriar Tyriar mentioned this issue Feb 6, 2025
Merged
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest
Projects
None yet
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

Be less strict when checking line continuation microsoft/vscode
2 participants
@Tyriar @meganrogge