Terminal suggest: Move to preview

[Tyriar]

Seems like the right time to move to preview now that things are a lot more stable and we're much better on testing now.

[meganrogge]

Would this just entail changing the setting name and migrating it?

[Tyriar]

Just replacing "experimental" with "preview" in settings tags and adjusting the descriptions of the settings if experimental is mentioned there:

vscode/src/vs/workbench/contrib/terminalContrib/suggest/common/terminalSuggestConfiguration.ts

Line 129 in db01139

tags: ['experimental'],

I also see that some settings don't have tags at all, we should add there:

vscode/src/vs/workbench/contrib/terminalContrib/suggest/common/terminalSuggestConfiguration.ts

Lines 78 to 121 in db01139

	[TerminalSuggestSettingId.QuickSuggestions]: {
	restricted: true,
	markdownDescription: localize('suggest.quickSuggestions', "Controls whether suggestions should automatically show up while typing. Also be aware of the {0}-setting which controls if suggestions are triggered by special characters.", `\`#${TerminalSuggestSettingId.SuggestOnTriggerCharacters}#\``),
	type: 'boolean',
	default: true,
	},
	[TerminalSuggestSettingId.SuggestOnTriggerCharacters]: {
	restricted: true,
	markdownDescription: localize('suggest.suggestOnTriggerCharacters', "Controls whether suggestions should automatically show up when typing trigger characters."),
	type: 'boolean',
	default: true,
	},
	[TerminalSuggestSettingId.RunOnEnter]: {
	restricted: true,
	markdownDescription: localize('suggest.runOnEnter', "Controls whether suggestions should run immediately when `Enter` (not `Tab`) is used to accept the result."),
	enum: ['ignore', 'never', 'exactMatch', 'exactMatchIgnoreExtension', 'always'],
	markdownEnumDescriptions: [
	localize('runOnEnter.ignore', "Ignore suggestions and send the enter directly to the shell without completing. This is used as the default value so the suggest widget is as unobtrusive as possible."),
	localize('runOnEnter.never', "Never run on `Enter`."),
	localize('runOnEnter.exactMatch', "Run on `Enter` when the suggestion is typed in its entirety."),
	localize('runOnEnter.exactMatchIgnoreExtension', "Run on `Enter` when the suggestion is typed in its entirety or when a file is typed without its extension included."),
	localize('runOnEnter.always', "Always run on `Enter`.")
	],
	default: 'ignore',
	},
	[TerminalSuggestSettingId.BuiltinCompletions]: {
	restricted: true,
	markdownDescription: localize('suggest.builtinCompletions', "Controls which built-in completions are activated. This setting can cause conflicts if custom shell completions are configured in the shell profile."),
	type: 'object',
	properties: {
	'pwshCode': {
	description: localize('suggest.builtinCompletions.pwshCode', 'Custom PowerShell argument completers will be registered for VS Code\'s `code` and `code-insiders` CLIs. This is currently very basic and always suggests flags and subcommands without checking context.'),
	type: 'boolean'
	},
	'pwshGit': {
	description: localize('suggest.builtinCompletions.pwshGit', 'Custom PowerShell argument completers will be registered for the `git` CLI.'),
	type: 'boolean'
	},
	},
	default: {
	pwshCode: true,
	pwshGit: true,
	}
	},