Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal suggest: Up to navigate history is opening suggest widget #239609

Closed
Tyriar opened this issue Feb 4, 2025 · 1 comment · Fixed by #239702
Closed

Terminal suggest: Up to navigate history is opening suggest widget #239609

Tyriar opened this issue Feb 4, 2025 · 1 comment · Fixed by #239702
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal-suggest unreleased Patch has not yet been released in VS Code Insiders
Milestone
February 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 4, 2025

The gif shows only pressing the up key which should never show suggest:

Image

Code that's meant to stop this:

vscode/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts

Lines 271 to 276 in 4e364a5

// Never request completions if the last key sequence was up or down as the user was likely
// navigating history
if (!this._lastUserData?.match(/^\x1b[\[O]?[A-D]$/)) {
this.requestCompletions();
sent = true;
}

We may need to duplicate this for trigger characters too?
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels Feb 4, 2025
@Tyriar Tyriar added this to the February 2025 milestone Feb 4, 2025
@Tyriar
Copy link
Member Author

Tyriar commented Feb 5, 2025

Cause:

Image

@Tyriar Tyriar mentioned this issue Feb 5, 2025
Merged
@Tyriar Tyriar self-assigned this Feb 5, 2025
@Tyriar Tyriar closed this as completed in 5446d62 Feb 5, 2025
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal-suggest unreleased Patch has not yet been released in VS Code Insiders
Projects
None yet
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

Don't show suggest widget when last input was arrow microsoft/vscode
2 participants
@Tyriar @meganrogge