Terminal suggest: Come up with list of terminal completion kinds we want to support

[Tyriar]

This will feed into the icons that each of these kinds would have.

Editor intellisense reference

What we have now:

export enum TerminalCompletionItemKind {
	File = 0,
	Folder = 1,
	Flag = 2,
	Method = 3,
	Argument = 4,
	Alias = 5,
}

An alias icon was requested in microsoft/vscode-codicons#279

This is what fig defines:

  type SuggestionType =
    | "folder"
    | "file"
    | "arg"
    | "subcommand"
    | "option"
    | "special"
    | "mixin"
    | "shortcut";

PowerShell command types from Get-Command:

Alias
Function
Filter
Cmdlet
ExternalScript
Application
Script
Configuration
All (this is a bit mask, maybe just part of how pwsh does enums?)

PowerShell completions types from TabExpansion2:

Value	Name	Description
0	Text	An unknown result type, kept as text only
1	History	A history result type like the items out of get-history
2	Command	A command result type like the items out of get-command
3	ProviderItem	A provider item
4	ProviderContainer	A provider container
5	Property	A property result type like the property items out of get-member
6	Method	A method result type like the method items out of get-member
7	ParameterName	A parameter name result type like the Parameters property out of get-command items
8	ParameterValue	A parameter value result type
9	Variable	A variable result type like the items out of get-childitem variable:
10	Namespace	A namespace
11	Type	A type name
12	Keyword	A keyword
13	DynamicKeyword	A dynamic keyword

[Tyriar]

The icons fig uses https://github.com/aws/amazon-q-developer-cli/tree/main/crates/fig_desktop/icons/autocomplete

[Tyriar]

Fig SuggestionType	VS Code TerminalCompletionItemKind
"folder"	TerminalCompletionItemKind.Folder
"file"	TerminalCompletionItemKind.File
"arg"	TerminalCompletionItemKind.Argument (this is only for non-specific arguments, like non-files?)
"subcommand"	TerminalCompletionItemKind.Method (should we rename this to Command?)
"option"	TerminalCompletionItemKind.Option
"special"	Not sure what this is?
"mixin"	Not sure what this is? symbol-snippet?
"shortcut"	TerminalCompletionItemKind.Suggestion + lightbulb? Is this a suggestion in fig?

? Should we have a flag icon? Ie. an option without a value

Fig's type to icon mapping https://github.com/aws/amazon-q-developer-cli/blob/f66e0b0e917ab185eef528dc36eca56b78ca8b5d/packages/autocomplete-app/src/components/SuggestionIcon.tsx#L151-L160

    const srcMap: Partial<Record<SuggestionType | "other", URL>> = {
      folder: new URL(localProtocol("path", `${iconPath}${name}`)),
      file: new URL(localProtocol("path", `${iconPath}${name}`)),
      subcommand: transformIconUri(new URL("fig://icon?type=command")),
      option: transformIconUri(new URL("fig://icon?type=option")),
      shortcut: new URL(localProtocol("template", "?color=3498db&badge=💡")),
      "auto-execute": transformIconUri(new URL("fig://icon?type=carrot")),
      arg: transformIconUri(new URL("fig://icon?type=box")),
      mixin: new URL(localProtocol("template", "?color=628dad&badge=➡️")),
    };

[Tyriar]

Proposed TerminalCompletionItemKind mapping to icons based on above:

TerminalCompletionItemKind	Codicon	Notes
TerminalCompletionItemKind.Folder	folder
TerminalCompletionItemKind.File	file (or language specific icon)
TerminalCompletionItemKind.Command	symbol-method	Renamed from Argument, this is also used for subcommands
TerminalCompletionItemKind.Option	new icon similar to question? or symbol-enum?	These are fig options that do have values
TerminalCompletionItemKind.OptionValue	symbol-enum-member	This is a fixed set of valid values, very similar to enums in the editor
TerminalCompletionItemKind.Flag	new icon of a flag or -f	These are fig options that do not have values
TerminalCompletionItemKind.Suggestion	lightbulb	Only add when we support the feature
TerminalCompletionItemKind.Snippet	symbol-snippet	Only add when we support the feature
TerminalCompletionItemKind.Alias	new icon	These are shell-level aliases like alias c=code

[meganrogge]

These look good to me. For Option, I think it would be confusing to use question.

[kkbrooks]

@davidhosejr can you do a holistic audit of the icons currently used in VS Code IntelliSense experience in the editor and see how that tracks with @Tyriar's estimates for what we need for the new Terminal IntelliSense experience? @Tyriar did an audit above and outlined where we'll likely need new icons.