Skip to content

Make checking for target framework unified #15462

@nohwnd

Description

@nohwnd

All the places where we check for runnerInfo.TargetFramework, they should most likely just check if it starts with net4 for .net framework or not. No concrete version other than that should be used.

Status Code File Line Column Project Containing Member Containing Type Kind Repository
InvokeVsTestForExecution(source, null, runnerInfo.TargetFramework, runSettings: testsettingsFile, null); S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\TranslationLayerTests\RunTestsWithDifferentConfigurationTests.cs 188 59 Microsoft.TestPlatform.Acceptance.IntegrationTests RunTestsWithTestSettingsInTpv0 RunTestsWithDifferentConfigurationTests Read
string RunnerInfo.TargetFramework { get; set; }
testEnvironment.TargetFramework = runnerInfo.TargetFramework; S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\AcceptanceTestBase.cs 75 54 Microsoft.TestPlatform.Acceptance.IntegrationTests SetTestEnvironment AcceptanceTestBase Read
if (!runnerInfo.TargetFramework.StartsWith("net4")) S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\ExecutionTests.cs 198 25 Microsoft.TestPlatform.Acceptance.IntegrationTests StackOverflowExceptionShouldBeLoggedToConsoleAndDiagLogFile ExecutionTests Read
!runnerInfo.TargetFramework.StartsWith("net4") S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\ExecutionTests.cs 228 25 Microsoft.TestPlatform.Acceptance.IntegrationTests UnhandleExceptionExceptionShouldBeLoggedToDiagLogFile ExecutionTests Read
TargetFramework = hostFramework, S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\Extension\CompatibilityRowsBuilder.cs 327 13 Microsoft.TestPlatform.Acceptance.IntegrationTests GetRunnerInfo CompatibilityRowsBuilder Write
TargetFramework = fmw, S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\Extension\NetCoreRunnerAttribute.cs 52 17 Microsoft.TestPlatform.Acceptance.IntegrationTests GetData NetCoreRunnerAttribute Write
TargetFramework = targetFramework, S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\Extension\NetCoreTargetFrameworkDataSourceAttribute.cs 50 13 Microsoft.TestPlatform.Acceptance.IntegrationTests AddRunnerDataRow NetCoreTargetFrameworkDataSourceAttribute Write
TargetFramework = fmw, S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\Extension\NetFrameworkRunnerAttribute.cs 54 17 Microsoft.TestPlatform.Acceptance.IntegrationTests GetData NetFrameworkRunnerAttribute Write
TargetFramework = AcceptanceTestBase.DesktopTargetFramework, S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\Extension\NetFullTargetFrameworkDataSourceAttribute.cs 58 17 Microsoft.TestPlatform.Acceptance.IntegrationTests GetData NetFullTargetFrameworkDataSourceAttribute Write
TargetFramework = AcceptanceTestBase.DesktopTargetFramework, S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\Extension\NetFullTargetFrameworkDataSourceAttribute.cs 78 21 Microsoft.TestPlatform.Acceptance.IntegrationTests GetData NetFullTargetFrameworkDataSourceAttribute Write
TargetFramework = AcceptanceTestBase.DesktopTargetFramework, S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\Extension\NetFullTargetFrameworkDataSourceAttribute.cs 96 21 Microsoft.TestPlatform.Acceptance.IntegrationTests GetData NetFullTargetFrameworkDataSourceAttribute Write
public bool IsNetFrameworkTarget => TargetFramework!.StartsWith("net4", StringComparison.InvariantCultureIgnoreCase); S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\Extension\RunnnerInfo.cs 46 41 Microsoft.TestPlatform.Acceptance.IntegrationTests IsNetFrameworkTarget RunnerInfo Read
$"TargetFramework = {TargetFramework}", S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\Extension\RunnnerInfo.cs 55 34 Microsoft.TestPlatform.Acceptance.IntegrationTests ToString RunnerInfo Read
if (runnerInfo.TargetFramework.Contains("netcore")) S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\FrameworkTests.cs 53 24 Microsoft.TestPlatform.Acceptance.IntegrationTests OnWrongFrameworkPassedTestRunShouldNotRun FrameworkTests Read
if (runnerInfo.TargetFramework.Contains("netcore")) S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\FrameworkTests.cs 63 24 Microsoft.TestPlatform.Acceptance.IntegrationTests OnWrongFrameworkPassedTestRunShouldNotRun FrameworkTests Read
if (runnerInfo.TargetFramework.Contains("net8") && isWindows) S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\FrameworkTests.cs 93 24 Microsoft.TestPlatform.Acceptance.IntegrationTests RunSpecificTestsShouldWorkWithFrameworkInCompatibleWarning FrameworkTests Read
["EXPECTED_TARGET_FRAMEWORK"] = runnerInfo.TargetFramework S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\MultitargetingTestHostTests.cs 31 56 Microsoft.TestPlatform.Acceptance.IntegrationTests TestRunInATesthostThatTargetsTheirChosenNETFramework MultitargetingTestHostTests Read
{runnerInfo.TargetFramework} S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\TranslationLayerTests\DifferentTestFrameworkSimpleTests.cs 98 57 Microsoft.TestPlatform.Acceptance.IntegrationTests RunTestsWithXunitAdapter DifferentTestFrameworkSimpleTests Read
var errorMessagePattern = runnerInfo.TargetFramework.StartsWith("net4") S:\p\vstest\test\Microsoft.TestPlatform.Acceptance.IntegrationTests\TranslationLayerTests\RunTests.cs 190 46 Microsoft.TestPlatform.Acceptance.IntegrationTests RunTestsShouldThrowOnStackOverflowException RunTests Read

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions