Skip to content

Nice restructuring — splitting to single-tfm and multi-tfm test projects makes the intent much clearer, and the new build.ps1 filter/category machinery is a good step toward faster PR pipelines. #15499

@nohwnd

Description

@nohwnd

Nice restructuring — splitting to single-tfm and multi-tfm test projects makes the intent much clearer, and the new build.ps1 filter/category machinery is a good step toward faster PR pipelines.

A few things I noticed:

Bugs (please fix):

  1. SkipIntegrationTestBuild is checked in IntegrationTestBuild.BuildTestAssetsForIntegrationTests but there's no early return — the build always runs regardless of the flag.
  2. Several Assert messages in EndSessionShouldEnsureVstestConsoleProcessDies (both in RunTests.cs and CodeCoverageTests.cs) have swapped/misleading failure messages that will be confusing if they ever fire.
  3. DiscoverTests.cs: The release/debug line-number conditional now has both branches asserting 22, making it dead code.

...

Originally posted by @Evangelink in #15484 (review)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions