Skip to content

Commit ee2a2cf

Browse files
gep13yodurr
gep13
authored and
yodurr
committed
Apply Choco Best Practices (#77)
* (maint) Corrected whitespace * (GH-15) Apply Choco Best Practices
1 parent f59fe23 commit ee2a2cf

11 files changed

+40
-40
lines changed

‎demos/chocolateyfest2018.ps1

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,21 +36,21 @@ executeScript "WSL.ps1";
3636
RefreshEnv
3737
executeScript "Docker.ps1";
3838

39-
choco install powershell-core
40-
choco install azure-cli
39+
choco install -y powershell-core
40+
choco install -y azure-cli
4141
Install-Module -Force Az
4242
Install-Module -Force posh-git
43-
choco install microsoftazurestorageexplorer
44-
choco install terraform
43+
choco install -y microsoftazurestorageexplorer
44+
choco install -y terraform
4545

4646
# Install tools in WSL instance
4747
write-host "Installing tools inside the WSL distro..."
4848
Ubuntu1804 run apt install ansible -y
4949
Ubuntu1804 run apt install nodejs -y
5050

5151
# personalize
52-
choco install microsoft-teams
53-
choco install office365business
52+
choco install -y microsoft-teams
53+
choco install -y office365business
5454

5555
# checkout recent projects
5656
mkdir C:\github

‎dev_app.ps1

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Description: Boxstarter Script
1+
# Description: Boxstarter Script
22
# Author: Microsoft
33
# Common dev settings for desktop app development
44

@@ -28,15 +28,15 @@ executeScript "RemoveDefaultApps.ps1";
2828
executeScript "CommonDevTools.ps1";
2929

3030
#--- Tools ---
31-
#--- Installing VS and VS Code with Git
31+
#--- Installing VS and VS Code with Git
3232
# See this for install args: https://chocolatey.org/packages/VisualStudio2017Community
33-
# https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-community
33+
# https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-community
3434
# https://docs.microsoft.com/en-us/visualstudio/install/use-command-line-parameters-to-install-visual-studio#list-of-workload-ids-and-component-ids
35-
# visualstudio2017community
35+
# visualstudio2017community
3636
# visualstudio2017professional
3737
# visualstudio2017enterprise
3838

39-
choco install visualstudio2017community -y --package-parameters "--add Microsoft.VisualStudio.Component.Git"
39+
choco install -y visualstudio2017community --package-parameters="'--add Microsoft.VisualStudio.Component.Git'"
4040
Update-SessionEnvironment #refreshing env due to Git install
4141

4242
#--- UWP Workload and installing Windows Template Studio ---

‎dev_app_desktop_.NET.ps1

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Description: Boxstarter Script
1+
# Description: Boxstarter Script
22
# Author: Microsoft
33
# Common dev settings for desktop app development
44

@@ -28,15 +28,15 @@ executeScript "RemoveDefaultApps.ps1";
2828
executeScript "CommonDevTools.ps1";
2929

3030
#--- Tools ---
31-
#--- Installing VS and VS Code with Git
31+
#--- Installing VS and VS Code with Git
3232
# See this for install args: https://chocolatey.org/packages/VisualStudio2017Community
33-
# https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-community
33+
# https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-community
3434
# https://docs.microsoft.com/en-us/visualstudio/install/use-command-line-parameters-to-install-visual-studio#list-of-workload-ids-and-component-ids
35-
# visualstudio2017community
35+
# visualstudio2017community
3636
# visualstudio2017professional
3737
# visualstudio2017enterprise
3838

39-
choco install visualstudio2017community -y --package-parameters "--add Microsoft.VisualStudio.Component.Git"
39+
choco install -y visualstudio2017community --package-parameters="'--add Microsoft.VisualStudio.Component.Git'"
4040
Update-SessionEnvironment #refreshing env due to Git install
4141

4242
#--- UWP Workload and installing Windows Template Studio ---
@@ -46,4 +46,4 @@ choco install -y visualstudio2017-workload-manageddesktop
4646
#--- reenabling critial items ---
4747
Enable-UAC
4848
Enable-MicrosoftUpdate
49-
Install-WindowsUpdate -acceptEula
49+
Install-WindowsUpdate -acceptEula

‎dev_app_desktop_cplusplus.ps1

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Description: Boxstarter Script
1+
# Description: Boxstarter Script
22
# Author: Microsoft
33
# Common dev settings for desktop app development
44

@@ -28,15 +28,15 @@ executeScript "RemoveDefaultApps.ps1";
2828
executeScript "CommonDevTools.ps1";
2929

3030
#--- Tools ---
31-
#--- Installing VS and VS Code with Git
31+
#--- Installing VS and VS Code with Git
3232
# See this for install args: https://chocolatey.org/packages/VisualStudio2017Community
33-
# https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-community
33+
# https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-community
3434
# https://docs.microsoft.com/en-us/visualstudio/install/use-command-line-parameters-to-install-visual-studio#list-of-workload-ids-and-component-ids
35-
# visualstudio2017community
35+
# visualstudio2017community
3636
# visualstudio2017professional
3737
# visualstudio2017enterprise
3838

39-
choco install visualstudio2017community -y --package-parameters "--add Microsoft.VisualStudio.Component.Git"
39+
choco install -y visualstudio2017community --package-parameters="'--add Microsoft.VisualStudio.Component.Git'"
4040
Update-SessionEnvironment #refreshing env due to Git install
4141

4242
#--- UWP Workload and installing Windows Template Studio ---
@@ -46,4 +46,4 @@ choco install -y visualstudio2017-workload-nativedesktop
4646
#--- reenabling critial items ---
4747
Enable-UAC
4848
Enable-MicrosoftUpdate
49-
Install-WindowsUpdate -acceptEula
49+
Install-WindowsUpdate -acceptEula

‎dev_app_desktop_uwp.ps1

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Description: Boxstarter Script
1+
# Description: Boxstarter Script
22
# Author: Microsoft
33
# Common dev settings for desktop app development
44

@@ -28,15 +28,15 @@ executeScript "RemoveDefaultApps.ps1";
2828
executeScript "CommonDevTools.ps1";
2929

3030
#--- Tools ---
31-
#--- Installing VS and VS Code with Git
31+
#--- Installing VS and VS Code with Git
3232
# See this for install args: https://chocolatey.org/packages/VisualStudio2017Community
33-
# https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-community
33+
# https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-community
3434
# https://docs.microsoft.com/en-us/visualstudio/install/use-command-line-parameters-to-install-visual-studio#list-of-workload-ids-and-component-ids
35-
# visualstudio2017community
35+
# visualstudio2017community
3636
# visualstudio2017professional
3737
# visualstudio2017enterprise
3838

39-
choco install visualstudio2017community -y --package-parameters "--add Microsoft.VisualStudio.Component.Git"
39+
choco install -y visualstudio2017community --package-parameters="'--add Microsoft.VisualStudio.Component.Git'"
4040
Update-SessionEnvironment #refreshing env due to Git install
4141

4242
#--- UWP Workload and installing Windows Template Studio ---
@@ -48,4 +48,4 @@ executeScript "GetUwpSamplesOffGithub.ps1";
4848
#--- reenabling critial items ---
4949
Enable-UAC
5050
Enable-MicrosoftUpdate
51-
Install-WindowsUpdate -acceptEula
51+
Install-WindowsUpdate -acceptEula

‎devops_azure.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ executeScript "WSL.ps1";
3535
RefreshEnv
3636
executeScript "Docker.ps1";
3737

38-
choco install powershell-core
39-
choco install azure-cli
38+
choco install -y powershell-core
39+
choco install -y azure-cli
4040
Install-Module -Force Az
41-
choco install microsoftazurestorageexplorer
42-
choco install terraform
41+
choco install -y microsoftazurestorageexplorer
42+
choco install -y terraform
4343

4444
# Install tools in WSL instance
4545
write-host "Installing tools inside the WSL distro..."

‎scripts/CommonDevTools.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
# tools we expect devs across many scenarios will want
33
choco install -y vscode
4-
choco install -y git -params '"/GitAndUnixToolsOnPath /WindowsTerminal"'
4+
choco install -y git --package-parameters="'/GitAndUnixToolsOnPath /WindowsTerminal'"
55
choco install -y python
66
choco install -y 7zip.install
77
choco install -y sysinternals

‎scripts/GetMLIDEAndTooling.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# Using vscode as a default IDE
22
choco install -y vscode
3-
choco install -y git -params '"/GitAndUnixToolsOnPath /WindowsTerminal"'
3+
choco install -y git --package-parameters="'/GitAndUnixToolsOnPath /WindowsTerminal'"

‎scripts/HyperV.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
choco install -y Microsoft-Hyper-V-All -source windowsFeatures
1+
choco install -y Microsoft-Hyper-V-All --source="'windowsFeatures'"

‎scripts/PythonMLTools.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Install python
2-
choco install python --version 3.5.4 -y
2+
choco install -y python --version=3.5.4
33

44
# Refresh path
55
refreshenv
@@ -16,4 +16,4 @@ pip install tensorflow
1616
pip install keras
1717

1818
# Get Visual Studio C++ Redistributables
19-
choco install vcredist2015
19+
choco install -y vcredist2015

0 commit comments

Comments
 (0)