dotnet dsc resource only works on second run

[claudiaregio]

Brief description of your issue

I have to run the configuration file twice for it to work, always fails on first run

Using Microsoft.DotNet.DSC/DotNetToolPackage

Steps to reproduce

1. Run this config file GlobalTool-TEST.zip

Expected behavior

For it to work on first run

Actual behavior

Only works on second try

Environment

Windows: Windows.Desktop v10.0.26100.2033
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.23.1911.0

Winget Directories

Logs %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User) %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User) %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root C:\Program Files\WinGet\Packages
Portable Package Root (x86) C:\Program Files (x86)\WinGet\Packages
Installer Downloads %USERPROFILE%\Downloads

Links

Privacy Statement https://aka.ms/winget-privacy
License Agreement https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting State

LocalManifestFiles Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride Disabled
LocalArchiveMalwareScanOverride Disabled
ProxyCommandLineOptions Disabled
DefaultProxy Disabled

[denelon]

First Run:

Second Run:

[denelon]

# yaml-language-server: $schema=https://aka.ms/configuration-dsc-schema/0.2
properties:
  resources:
    - resource: Microsoft.WinGet.DSC/WinGetPackage
      id: install-dotnet9-SDK
      directives:
        description: Install .NET 9 SDK
        securityContext: elevated
      settings:
        id: Microsoft.DotNet.SDK.9
        source: winget
    - resource: Microsoft.DotNet.DSC/DotNetToolPackage
      dependsOn:
        - install-dotnet9-SDK
      directives:
        description: Install Microsoft.dotnet-scaffold
        allowPrerelease: true
      settings:
        PackageId: microsoft.dotnet-scaffold
        Version: 9.0.1
        Prerelease: true
        Exist: true
    - resource: Microsoft.DotNet.DSC/DotNetToolPackage
      dependsOn:
          - install-dotnet9-SDK
      directives:
        description: Install Microsoft.dotnet-scaffold-aspire
        allowPrerelease: true
      settings:
        PackageId: microsoft.dotnet-scaffold-aspire
        Version: 9.0.1
        Prerelease: true
        Exist: true
    - resource: Microsoft.DotNet.DSC/DotNetToolPackage
      dependsOn:
        - install-dotnet9-SDK
      directives:
        description: Install Microsoft.dotnet-scaffold-aspnet
        allowPrerelease: true
      settings:
        PackageId: microsoft.dotnet-scaffold-aspnet
        Version: 9.0.1
        Prerelease: true
        Exist: true
  configurationVersion: 0.2.0

[denelon]

@Gijsreyn any clue on this one? I was suspecting it might not be on the path, but that doesn't explain why the second and third instances succeed.

[Gijsreyn]

Hi @denelon, yes and I've scratched my head a couple of times until I finally found it. I think this picture says a thousand words:

So basically, when the class was trying to get instantiated, the output from the list operation couldn't be properly handled. To be more specific, the Get-InstalledDotNetToolPackages functions runs dotnet tool list --global. The full output of this is captured and another function is used to filter that result in a proper PowerShell object, which is Convert-DotNetToolOutput.

This function didn't take into account the first run experience. I've hit up #154 to set the environment variable. Thinking about it also, now that .NET SDK is GA, we can also switch to the --format=JSON parameter, reducing the need for this function. But I can recognize that we still want to support older versions. Just throwing it in here.

You mind informing one of your favorite engineers to approve the PR? It's a tiny one. Cheers! :)

[denelon]

Thanks so much @Gijsreyn !!!

@AmelBawa-msft approved and merged. Next is the publish phase.

[claudiaregio]

[heart] Claudia Regio reacted to your message:

…

________________________________