Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winmd_reader/view.h: add a missing #include <utility> #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valgur
Copy link

@valgur valgur commented Dec 10, 2024

Fixes

include/impl/winmd_reader/view.h: In constructor ‘winmd::reader::byte_view::byte_view(winmd::reader::byte_view&&)’:
include/impl/winmd_reader/view.h:44:26: error: ‘exchange’ is not a member of ‘std’
   44 |             m_first(std::exchange(other.m_first, {})),
      |                          ^~~~~~~~

when compiling with aarch64-linux-gnu-g++-14.

@valgur valgur changed the title view.h: add a missing #include <utility> winmd_reader/view.h: add a missing #include <utility> Dec 10, 2024
@DefaultRyan
Copy link
Member

Why are you including view.h without including base.h. The headers aren't designed to work in isolation.

@valgur
Copy link
Author

valgur commented Jan 31, 2025

Just put the missing include sonewhere, please.

I encountered this when trying to build https://github.com/conan-io/conan-center-index/blob/master/recipes/winmd/all/conanfile.py

@DefaultRyan
Copy link
Member

Just put the missing include sonewhere, please.

I encountered this when trying to build https://github.com/conan-io/conan-center-index/blob/master/recipes/winmd/all/conanfile.py

It already is, in impl/base.h. And that file is included by winmd_reader.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants