[Bug]kafka组件@KafkaListener装饰器装饰的方法如果返回 true 执行 commit 会报错 #4042
Closed
Yuliang-Lee
started this conversation in
General / 闲聊
Replies: 2 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
问题一:
![image](https://private-user-images.githubusercontent.com/6936358/363288130-f0a08f0e-0daf-45f7-be9c-6e1822957199.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MjIxMzMsIm5iZiI6MTczOTUyMTgzMywicGF0aCI6Ii82OTM2MzU4LzM2MzI4ODEzMC1mMGEwOGYwZS0wZGFmLTQ1ZjctYmU5Yy02ZTE4MjI5NTcxOTkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMDgzMDMzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTlkZmZmN2YzMzMyZmZmYTZmNGFiZDg0YzczOTBjMTI2Zjg4YmVkNmY1NjgxNGNhNzQ4NTc5ZTJlNGJmMTEwMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.s8JA70oVQyAggbJ1Tf66keNc0w18XTzBbElypsZ2C4o)
https://github.com/midwayjs/midway/blob/main/packages/kafka/src/framework.ts#L138
这一行代码的传参有问题,会导致报错
问题二:
这个返回
true
就会触发commit
的逻辑在文档里也没说明,这里建议文档加上或者去掉这个 commit 的逻辑Beta Was this translation helpful? Give feedback.
All reactions