Merge pull request #140 from lmcardle/patch-1

cancel scheduled debounce when service destroyed

Author: mike-north

addon/services/resize.js

@@ -3,7 +3,7 @@ import Service from '@ember/service';
 import Evented from '@ember/object/evented';
 import { classify } from '@ember/string';
 import { oneWay, readOnly } from '@ember/object/computed';
-import { debounce } from '@ember/runloop';
+import { debounce, cancel } from '@ember/runloop';
 import EmberObject, { set, getWithDefault } from '@ember/object';
 
 // jscs:disable disallowDirectPropertyAccess
@@ -15,7 +15,6 @@ export default Base.extend(Evented, {
   _oldHeight: window.innerHeight,
   _oldWidthDebounced: window.innerWidth,
   _oldHeightDebounced: window.innerHeight,
-
   debounceTimeout: oneWay('defaultDebounceTimeout'),
   widthSensitive: oneWay('defaultWidthSensitive'),
   heightSensitive: oneWay('defaultHeightSensitive'),
@@ -28,7 +27,8 @@ export default Base.extend(Evented, {
     this._setDefaults();
     this._onResizeHandler = evt => {
       this._fireResizeNotification(evt);
-      debounce(this, this._fireDebouncedResizeNotification, evt, this.get('debounceTimeout'));
+      let scheduledDebounce = debounce(this, this._fireDebouncedResizeNotification, evt, this.get('debounceTimeout'));
+      this._scheduledDebounce = scheduledDebounce;
     };
     if (typeof FastBoot === 'undefined') {
       this._installResizeListener();
@@ -40,6 +40,7 @@ export default Base.extend(Evented, {
     if (typeof FastBoot === 'undefined') {
       this._uninstallResizeListener();
     }
+    this._cancelScheduledDebounce();
   },
 
   _setDefaults() {
@@ -76,6 +77,10 @@ export default Base.extend(Evented, {
     window.removeEventListener('resize', this._onResizeHandler);
   },
 
+  _cancelScheduledDebounce() {
+    cancel(this._scheduledDebounce);
+  },
+
   _fireResizeNotification(evt) {
     const { innerWidth, innerHeight } = window;
     if (this._hasWindowSizeChanged(innerWidth, innerHeight)) {