Remove the avcodec_free_context(&codec_context) -- seems to cause a double free.

mikebrady · mikebrady · commit e28c566a7db9 · 2024-07-16T12:58:37.000+01:00
diff --git a/rtp.c b/rtp.c
@@ -2094,10 +2094,10 @@ void avcodec_alloc_context3_cleanup_handler(void *arg) {
   av_free(codec_context);
 }
 
-void avcodec_open2_cleanup_handler(void *arg) {
-  debug(3, "avcodec_open2_cleanup_handler");
-  AVCodecContext *codec_context = arg;
-  avcodec_free_context(&codec_context);
+void avcodec_open2_cleanup_handler(__attribute__((unused)) void *arg) {
+  debug(3, "avcodec_open2_cleanup_handler -- does nothing right now");
+  // AVCodecContext *codec_context = arg;
+  // avcodec_free_context(&codec_context);
 }
 
 void av_parser_init_cleanup_handler(void *arg) {

Original file line number	Diff line number	Diff line change
`@@ -2094,10 +2094,10 @@ void avcodec_alloc_context3_cleanup_handler(void *arg) {`
`2094`	`2094`	`av_free(codec_context);`
`2095`	`2095`	`}`
`2096`	`2096`
`2097`		`-void avcodec_open2_cleanup_handler(void *arg) {`
`2098`		`- debug(3, "avcodec_open2_cleanup_handler");`
`2099`		`- AVCodecContext *codec_context = arg;`
`2100`		`- avcodec_free_context(&codec_context);`
	`2097`	`+void avcodec_open2_cleanup_handler(__attribute__((unused)) void *arg) {`
	`2098`	`+ debug(3, "avcodec_open2_cleanup_handler -- does nothing right now");`
	`2099`	`+ // AVCodecContext *codec_context = arg;`
	`2100`	`+ // avcodec_free_context(&codec_context);`
`2101`	`2101`	`}`
`2102`	`2102`
`2103`	`2103`	`void av_parser_init_cleanup_handler(void *arg) {`