Skip to content

Commit 10408c1

Browse files
committed
fix: fix assertions for dapr-bot and check-lint-version
Signed-off-by: mikeee <[email protected]>
1 parent b5187d0 commit 10408c1

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

Diff for: .github/workflows/dapr-bot/event_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ func TestProcessEvent(t *testing.T) {
6969
func TestGetIssueAssignees(t *testing.T) {
7070
t.Run("get assignees", func(t *testing.T) {
7171
assignees := testEvent.GetIssueAssignees()
72-
assert.Equal(t, 1, len(assignees))
72+
assert.Len(t, len(assignees), 1)
7373
assert.Equal(t, "testAssignee", assignees[0])
7474
})
7575
}

Diff for: tools/check-lint-version/main_test.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -49,23 +49,23 @@ func TestGetCurrentVersion(t *testing.T) {
4949

5050
func TestIsVersionValid(t *testing.T) {
5151
t.Run("compare versions - exactly equal to", func(t *testing.T) {
52-
assert.Equal(t, true, isVersionValid("v1.54.2", "v1.54.2"))
52+
assert.True(t, true, isVersionValid("v1.54.2", "v1.54.2"))
5353
})
5454

5555
t.Run("compare versions - patch version greater (workflow)", func(t *testing.T) {
56-
assert.Equal(t, true, isVersionValid("v1.54.3", "v1.54.2"))
56+
assert.True(t, true, isVersionValid("v1.54.3", "v1.54.2"))
5757
})
5858

5959
t.Run("compare versions - patch version greater (installed)", func(t *testing.T) {
60-
assert.Equal(t, true, isVersionValid("v1.54.2", "v1.54.3"))
60+
assert.True(t, true, isVersionValid("v1.54.2", "v1.54.3"))
6161
})
6262

6363
t.Run("compare versions - invalid (installed)", func(t *testing.T) {
64-
assert.Equal(t, false, isVersionValid("v1.54.2", "v1.52.2"))
64+
assert.False(t, false, isVersionValid("v1.54.2", "v1.52.2"))
6565
})
6666

6767
t.Run("compare versions - invalid (workflow)", func(t *testing.T) {
68-
assert.Equal(t, false, isVersionValid("v1.52.2", "v1.54.2"))
68+
assert.False(t, false, isVersionValid("v1.52.2", "v1.54.2"))
6969
})
7070
}
7171

0 commit comments

Comments
 (0)