Fix SqlServer bulkinsert issues breaking the integration tests.

This issue was caused by a combination of a recent changes to keepIdentity handling and some legacy handling that automatically
enables keepIdentity whenever a table has an identity value.

As there was no way to override the behavior it was no longer possible to autogenerate identity values, as we (and probably
our users) do in many scenarios. This caused > 20 test failures.

As there is no easy way to unbreak this I removed the automatically setting keep-identity and cleaned up the arguments to
properly allow setting the value as normal Enum (without nullable wrapper). At the same time I introduced ILogger like
in the non-bulk api and forwarded that wherever possible (and where I did not forget something).

This fixes all the SqlServer Bulkinsert integrationtests.

Author: rhuijben

RepoDb.Extensions/RepoDb.SqlServer.BulkOperations/RepoDb.SqlServer.BulkOperations/Base/BulkDelete.cs

@@ -1,12 +1,12 @@
-using RepoDb.Extensions;
-using System;
+using System;
 using System.Collections.Generic;
 using System.Data;
 using System.Data.Common;
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.Data.SqlClient;
+using RepoDb.Extensions;
 using RepoDb.Interfaces;
 
 namespace RepoDb
@@ -30,18 +30,20 @@ public static partial class SqlConnectionExtension
         /// <param name="isReturnIdentity"></param>
         /// <param name="usePhysicalPseudoTempTable"></param>
         /// <param name="transaction"></param>
+        /// <param name="trace"></param>
         /// <returns></returns>
         private static int BulkInsertInternalBase<TEntity>(SqlConnection connection,
             string tableName,
             IEnumerable<TEntity> entities,
-            IEnumerable<BulkInsertMapItem> mappings = null,
+            IEnumerable<BulkInsertMapItem>? mappings = null,
             SqlBulkCopyOptions options = default,
-            string hints = null,
+            string? hints = null,
             int? bulkCopyTimeout = null,
             int? batchSize = null,
-            bool? isReturnIdentity = null,
-            bool? usePhysicalPseudoTempTable = null,
-            SqlTransaction transaction = null)
+            bool isReturnIdentity = false,
+            bool usePhysicalPseudoTempTable = false,
+            SqlTransaction? transaction = null,
+            ITrace? trace = null)
             where TEntity : class
         {
             // Validate
@@ -140,7 +142,7 @@ private static int BulkInsertInternalBase<TEntity>(SqlConnection connection,
 
                     // Drop the table after used
                     sql = GetDropTemporaryTableSqlText(tempTableName, dbSetting);
-                    connection.ExecuteNonQuery(sql, transaction: transaction);
+                    connection.ExecuteNonQuery(sql, transaction: transaction, trace: trace);
                 }
 
                 CommitTransaction(transaction, hasTransaction);
@@ -154,7 +156,7 @@ private static int BulkInsertInternalBase<TEntity>(SqlConnection connection,
             {
                 DisposeTransaction(transaction, hasTransaction);
             }
-            
+
             // Return the result
             return result;
         }
@@ -174,11 +176,11 @@ private static int BulkInsertInternalBase<TEntity>(SqlConnection connection,
         internal static int BulkInsertInternalBase(SqlConnection connection,
             string tableName,
             DbDataReader reader,
-            IEnumerable<BulkInsertMapItem> mappings = null,
+            IEnumerable<BulkInsertMapItem>? mappings = null,
             SqlBulkCopyOptions options = default,
             int? bulkCopyTimeout = null,
             int? batchSize = null,
-            SqlTransaction transaction = null)
+            SqlTransaction? transaction = null)
         {
             // Validate
             if (!reader.HasRows)
@@ -253,7 +255,7 @@ internal static int BulkInsertInternalBase(SqlConnection connection,
             {
                 DisposeTransaction(transaction, hasTransaction);
             }
-            
+
             // Return the result
             return result;
         }
@@ -273,19 +275,21 @@ internal static int BulkInsertInternalBase(SqlConnection connection,
         /// <param name="isReturnIdentity"></param>
         /// <param name="usePhysicalPseudoTempTable"></param>
         /// <param name="transaction"></param>
+        /// <param name="trace"></param>
         /// <returns></returns>
         internal static int BulkInsertInternalBase(SqlConnection connection,
             string tableName,
             DataTable dataTable,
             DataRowState? rowState = null,
-            IEnumerable<BulkInsertMapItem> mappings = null,
+            IEnumerable<BulkInsertMapItem>? mappings = null,
             SqlBulkCopyOptions options = default,
-            string hints = null,
+            string? hints = null,
             int? bulkCopyTimeout = null,
             int? batchSize = null,
-            bool? isReturnIdentity = null,
-            bool? usePhysicalPseudoTempTable = null,
-            SqlTransaction transaction = null)
+            bool isReturnIdentity = false,
+            bool usePhysicalPseudoTempTable = false,
+            SqlTransaction? transaction = null,
+            ITrace? trace = null)
         {
             // Validate
             if (dataTable?.Rows.Count <= 0)
@@ -391,7 +395,7 @@ internal static int BulkInsertInternalBase(SqlConnection connection,
 
                         // Drop the table after used
                         sql = GetDropTemporaryTableSqlText(tempTableName, dbSetting);
-                        connection.ExecuteNonQuery(sql, transaction: transaction);
+                        connection.ExecuteNonQuery(sql, transaction: transaction, trace: trace);
                     }
                 }
 
@@ -406,7 +410,7 @@ internal static int BulkInsertInternalBase(SqlConnection connection,
             {
                 DisposeTransaction(transaction, hasTransaction);
             }
-            
+
             // Return the result
             return result;
         }
@@ -430,19 +434,21 @@ internal static int BulkInsertInternalBase(SqlConnection connection,
         /// <param name="isReturnIdentity"></param>
         /// <param name="usePhysicalPseudoTempTable"></param>
         /// <param name="transaction"></param>
+        /// <param name="trace"></param>
         /// <param name="cancellationToken"></param>
         /// <returns></returns>
         private static async Task<int> BulkInsertAsyncInternalBase<TEntity>(SqlConnection connection,
             string tableName,
             IEnumerable<TEntity> entities,
-            IEnumerable<BulkInsertMapItem> mappings = null,
+            IEnumerable<BulkInsertMapItem>? mappings = null,
             SqlBulkCopyOptions options = default,
-            string hints = null,
+            string? hints = null,
             int? bulkCopyTimeout = null,
             int? batchSize = null,
-            bool? isReturnIdentity = null,
-            bool? usePhysicalPseudoTempTable = null,
-            SqlTransaction transaction = null,
+            bool isReturnIdentity = false,
+            bool usePhysicalPseudoTempTable = false,
+            SqlTransaction? transaction = null,
+            ITrace? trace = null,
             CancellationToken cancellationToken = default)
             where TEntity : class
         {
@@ -545,7 +551,7 @@ private static async Task<int> BulkInsertAsyncInternalBase<TEntity>(SqlConnectio
 
                     // Drop the table after used
                     sql = GetDropTemporaryTableSqlText(tempTableName, dbSetting);
-                    await connection.ExecuteNonQueryAsync(sql, transaction: transaction, cancellationToken: cancellationToken);
+                    await connection.ExecuteNonQueryAsync(sql, transaction: transaction, trace: trace, cancellationToken: cancellationToken);
                 }
 
                 CommitTransaction(transaction, hasTransaction);
@@ -559,11 +565,11 @@ private static async Task<int> BulkInsertAsyncInternalBase<TEntity>(SqlConnectio
             {
                 DisposeTransaction(transaction, hasTransaction);
             }
-            
+
             // Return the result
             return result;
         }
-        
+
         /// <summary>
         ///
         /// </summary>
@@ -580,11 +586,11 @@ private static async Task<int> BulkInsertAsyncInternalBase<TEntity>(SqlConnectio
         internal static async Task<int> BulkInsertAsyncInternalBase(SqlConnection connection,
             string tableName,
             DbDataReader reader,
-            IEnumerable<BulkInsertMapItem> mappings = null,
+            IEnumerable<BulkInsertMapItem>? mappings = null,
             SqlBulkCopyOptions options = default,
             int? bulkCopyTimeout = null,
             int? batchSize = null,
-            SqlTransaction transaction = null,
+            SqlTransaction? transaction = null,
             CancellationToken cancellationToken = default)
         {
             // Validate
@@ -661,7 +667,7 @@ internal static async Task<int> BulkInsertAsyncInternalBase(SqlConnection connec
             {
                 DisposeTransaction(transaction, hasTransaction);
             }
-            
+
             // Return the result
             return result;
         }
@@ -681,20 +687,22 @@ internal static async Task<int> BulkInsertAsyncInternalBase(SqlConnection connec
         /// <param name="isReturnIdentity"></param>
         /// <param name="usePhysicalPseudoTempTable"></param>
         /// <param name="transaction"></param>
+        /// <param name="trace"></param>
         /// <param name="cancellationToken"></param>
         /// <returns></returns>
         internal static async Task<int> BulkInsertAsyncInternalBase(SqlConnection connection,
             string tableName,
             DataTable dataTable,
             DataRowState? rowState = null,
-            IEnumerable<BulkInsertMapItem> mappings = null,
+            IEnumerable<BulkInsertMapItem>? mappings = null,
             SqlBulkCopyOptions options = default,
-            string hints = null,
+            string? hints = null,
             int? bulkCopyTimeout = null,
             int? batchSize = null,
-            bool? isReturnIdentity = null,
-            bool? usePhysicalPseudoTempTable = null,
-            SqlTransaction transaction = null,
+            bool isReturnIdentity = false,
+            bool usePhysicalPseudoTempTable = false,
+            SqlTransaction? transaction = null,
+            ITrace? trace = null,
             CancellationToken cancellationToken = default)
         {
             // Validate
@@ -752,7 +760,7 @@ internal static async Task<int> BulkInsertAsyncInternalBase(SqlConnection connec
 
                 // Pseudo temp table
                 var withPseudoExecution = isReturnIdentity == true && identityDbField != null;
-                var tempTableName = await CreateBulkInsertTempTableIfNecessaryAsync(connection, 
+                var tempTableName = await CreateBulkInsertTempTableIfNecessaryAsync(connection,
                     tableName,
                     usePhysicalPseudoTempTable,
                     transaction,
@@ -803,7 +811,7 @@ internal static async Task<int> BulkInsertAsyncInternalBase(SqlConnection connec
 
                         // Drop the table after used
                         sql = GetDropTemporaryTableSqlText(tempTableName, dbSetting);
-                        await connection.ExecuteNonQueryAsync(sql, transaction: transaction, cancellationToken: cancellationToken);
+                        await connection.ExecuteNonQueryAsync(sql, transaction: transaction, trace: trace, cancellationToken: cancellationToken);
                     }
                 }
 
@@ -818,30 +826,31 @@ internal static async Task<int> BulkInsertAsyncInternalBase(SqlConnection connec
             {
                 DisposeTransaction(transaction, hasTransaction);
             }
-            
+
             // Return the result
             return result;
         }
 
         #endregion
-        
+
         private static string CreateBulkInsertTempTableIfNecessary<TSqlTransaction>(
             IDbConnection connection,
             string tableName,
             bool? usePhysicalPseudoTempTable,
             TSqlTransaction transaction,
             bool withPseudoExecution,
             IDbSetting dbSetting,
-            IEnumerable<Field> fields)
+            IEnumerable<Field> fields,
+            ITrace? trace = null)
             where TSqlTransaction : DbTransaction
         {
-            if (withPseudoExecution == false) 
+            if (withPseudoExecution == false)
                 return null;
 
             var tempTableName = CreateBulkInsertTempTableName(tableName, usePhysicalPseudoTempTable, dbSetting);
             var sql = GetCreateTemporaryTableSqlText(tableName, tempTableName, fields, dbSetting, true);
 
-            connection.ExecuteNonQuery(sql, transaction: transaction);
+            connection.ExecuteNonQuery(sql, transaction: transaction, trace: trace);
 
             return tempTableName;
         }
@@ -852,17 +861,18 @@ private static async Task<string> CreateBulkInsertTempTableIfNecessaryAsync<TSql
             TSqlTransaction transaction,
             bool withPseudoExecution,
             IDbSetting dbSetting,
-            IEnumerable<Field> fields, 
-            CancellationToken cancellationToken)
+            IEnumerable<Field> fields,
+            CancellationToken cancellationToken,
+            ITrace? trace = null)
             where TSqlTransaction : DbTransaction
         {
-            if (withPseudoExecution == false) 
+            if (withPseudoExecution == false)
                 return null;
 
             var tempTableName = CreateBulkInsertTempTableName(tableName, usePhysicalPseudoTempTable, dbSetting);
             var sql = GetCreateTemporaryTableSqlText(tableName, tempTableName, fields, dbSetting, true);
 
-            await connection.ExecuteNonQueryAsync(sql, transaction: transaction, cancellationToken: cancellationToken);
+            await connection.ExecuteNonQueryAsync(sql, transaction: transaction, trace: trace, cancellationToken: cancellationToken);
 
             return tempTableName;
         }