Merge pull request #45 from mikeshultz/hexbytes

refactor: use isinstance() instead of type() == x, to allow support for subclasses

Author: mikeshultz

ledgereth/messages.py

@@ -40,7 +40,7 @@ def sign_message(
         message = message.encode("utf-8")
 
     # Silence mypy due to type cohersion above
-    assert type(message) == bytes
+    assert isinstance(message, bytes)
 
     encoded = struct.pack(">I", len(message))
     encoded += message
@@ -125,8 +125,8 @@ def sign_typed_data_draft(
         message_hash = message_hash.encode("utf-8")
 
     # Silence mypy due to type cohersion above
-    assert type(domain_hash) == bytes
-    assert type(message_hash) == bytes
+    assert isinstance(domain_hash, bytes)
+    assert isinstance(message_hash, bytes)
 
     encoded = domain_hash + message_hash
 

ledgereth/transactions.py

@@ -203,8 +203,8 @@ def create_transaction(
         data = decode_hex(data)
 
     # be cool mypy
-    assert type(destination) == bytes
-    assert type(data) == bytes
+    assert isinstance(destination, bytes)
+    assert isinstance(data, bytes)
 
     # EIP-1559 transactions should never have gas_price
     if gas_price and (max_priority_fee_per_gas or max_fee_per_gas):

ledgereth/utils.py

@@ -138,7 +138,7 @@ def decode_web3_access_list(
         if "storageKeys" not in item:
             raise ValueError(f"Access list item at position {idx} missing storageKeys")
 
-        assert type(item["address"]) == str
+        assert isinstance(item["address"], str)
 
         work_list.append(
             (