Skip to content

Commit 36a51cd

Browse files
committed
Fixes some tests
Since Ruby 3 passing method argumentes changed. A Hash won't be converted to a keyword argument anymore. Therefore, keyword argumentes needs to be entered explicitly by default. To keep the behaviour double splat needs to be added to hash arguments. See https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
1 parent 6871d5d commit 36a51cd

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

test/integration/macro_dialog_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ def teardown
2525
end
2626

2727
test 'render macro diaglog without svg' do
28-
with_settings(redmine_drawio({ drawio_svg_enabled: false })) do
28+
with_settings(redmine_drawio(**{ drawio_svg_enabled: false })) do
2929
render_marcro_dialog
3030
assert_select 'input[value=?]', 'svg', 0
3131
end
3232
end
3333

3434
test 'render macro diaglog with svg' do
35-
with_settings(redmine_drawio({ drawio_svg_enabled: true })) do
35+
with_settings(redmine_drawio(**{ drawio_svg_enabled: true })) do
3636
render_marcro_dialog
3737
assert_select 'input[value=?]', 'svg'
3838
end

test/unit/drawio_settings_helper_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ def teardown
1414
end
1515

1616
def test_svg_disabled
17-
with_settings(redmine_drawio({ drawio_svg_enabled: false })) do
17+
with_settings(redmine_drawio(**{ drawio_svg_enabled: false })) do
1818
assert_not svg_enabled?
1919
end
2020
end
2121

2222
def test_svg_enabled
23-
with_settings(redmine_drawio({ drawio_svg_enabled: true })) do
23+
with_settings(redmine_drawio(**{ drawio_svg_enabled: true })) do
2424
assert svg_enabled?
2525
end
2626
end

0 commit comments

Comments
 (0)