clippy_output.txt

    Checking cfg-if v1.0.4
    Checking libc v0.2.183
    Checking smallvec v1.15.1
    Checking pin-project-lite v0.2.17
    Checking itoa v1.0.18
   Compiling serde_core v1.0.228
    Checking zeroize v1.8.2
    Checking bytes v1.11.1
    Checking once_cell v1.21.4
    Checking scopeguard v1.2.0
    Checking lock_api v0.4.14
    Checking parking_lot_core v0.9.12
    Checking log v0.4.29
    Checking parking_lot v0.12.5
    Checking errno v0.3.14
    Checking memchr v2.8.0
    Checking signal-hook-registry v1.4.8
    Checking mio v1.2.0
    Checking socket2 v0.6.3
    Checking tracing-core v0.1.36
    Checking tokio v1.50.0
   Compiling serde v1.0.228
    Checking tracing v0.1.44
    Checking libm v0.2.16
    Checking num-traits v0.2.19
    Checking subtle v2.6.1
    Checking getrandom v0.2.17
    Checking typenum v1.19.0
    Checking const-oid v0.9.6
   Compiling serde_json v1.0.149
    Checking generic-array v0.14.9
    Checking zmij v1.0.21
    Checking utf8parse v0.2.2
    Checking anstyle-parse v1.0.0
    Checking is_terminal_polyfill v1.70.2
    Checking anstyle-query v1.1.5
    Checking futures-core v0.3.32
    Checking anstyle v1.0.14
    Checking colorchoice v1.0.5
    Checking anstream v1.0.0
    Checking strsim v0.11.1
    Checking hashbrown v0.16.1
    Checking clap_lex v1.1.0
    Checking iana-time-zone v0.1.65
    Checking equivalent v1.0.2
    Checking chrono v0.4.44
    Checking indexmap v2.13.0
    Checking clap_builder v4.6.0
   Compiling zbobr-macros v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-macros)
    Checking clap v4.6.0
    Checking ref-cast v1.0.25
    Checking anyhow v1.0.102
    Checking block-buffer v0.10.4
    Checking crypto-common v0.1.6
    Checking rand_core v0.6.4
    Checking dyn-clone v1.0.20
    Checking futures-sink v0.3.32
    Checking schemars v1.2.1
   Compiling jobserver v0.1.34
    Checking digest v0.10.7
    Checking base64ct v1.8.3
   Compiling cc v1.2.58
    Checking pem-rfc7468 v0.7.0
    Checking futures-channel v0.3.32
    Checking zbobr-utility v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-utility)
    Checking zerofrom v0.1.6
    Checking der v0.7.10
    Checking stable_deref_trait v1.2.1
    Checking futures-task v0.3.32
    Checking futures-io v0.3.32
    Checking slab v0.4.12
    Checking spki v0.7.3
    Checking yoke v0.8.1
    Checking futures-util v0.3.32
    Checking zbobr-api v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-api)
warning: this `if` statement can be collapsed
   --> zbobr-api/src/config.rs:218:13
    |
218 | /             if let Some(ref target) = stage.on_success.as_ref().and_then(|t| t.next.as_ref()) {
219 | |                 if !self.stages.contains_key(target.as_str()) {
220 | |                     anyhow::bail!(
221 | |                         "Pipeline '{}' stage '{}' on_success references unknown stage '{}'",
...   |
227 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
    = note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
    |
218 ~             if let Some(ref target) = stage.on_success.as_ref().and_then(|t| t.next.as_ref())
219 ~                 && !self.stages.contains_key(target.as_str()) {
220 |                     anyhow::bail!(
...
225 |                     );
226 ~                 }
    |

warning: this `if` statement can be collapsed
   --> zbobr-api/src/config.rs:228:13
    |
228 | /             if let Some(ref target) = stage.on_failure.as_ref().and_then(|t| t.next.as_ref()) {
229 | |                 if !self.stages.contains_key(target.as_str()) {
230 | |                     anyhow::bail!(
231 | |                         "Pipeline '{}' stage '{}' on_failure references unknown stage '{}'",
...   |
237 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
228 ~             if let Some(ref target) = stage.on_failure.as_ref().and_then(|t| t.next.as_ref())
229 ~                 && !self.stages.contains_key(target.as_str()) {
230 |                     anyhow::bail!(
...
235 |                     );
236 ~                 }
    |

warning: this `if` statement can be collapsed
   --> zbobr-api/src/config.rs:238:13
    |
238 | /             if let Some(ref target) = stage.on_intermediate.as_ref().and_then(|t| t.next.as_ref()) {
239 | |                 if !self.stages.contains_key(target.as_str()) {
240 | |                     anyhow::bail!(
241 | |                         "Pipeline '{}' stage '{}' on_intermediate references unknown stage '{}'",
...   |
247 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
238 ~             if let Some(ref target) = stage.on_intermediate.as_ref().and_then(|t| t.next.as_ref())
239 ~                 && !self.stages.contains_key(target.as_str()) {
240 |                     anyhow::bail!(
...
245 |                     );
246 ~                 }
    |

warning: this `if` statement can be collapsed
   --> zbobr-api/src/config.rs:385:9
    |
385 | /         if let Some(pipeline) = self.pipelines.get(default.as_str()) {
386 | |             if let Some((name, stage)) = pipeline
387 | |                 .stages
388 | |                 .iter()
...   |
396 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
385 ~         if let Some(pipeline) = self.pipelines.get(default.as_str())
386 ~             && let Some((name, stage)) = pipeline
387 |                 .stages
...
394 |                     .map(|(p, _)| (p, name.as_str(), stage));
395 ~             }
    |

warning: this `if` statement can be collapsed
   --> zbobr-api/src/config.rs:454:21
    |
454 | /                     if let Some(role) = &stage.role {
455 | |                         if !self.roles.contains_key(role) {
456 | |                             anyhow::bail!(
457 | |                                 "Stage '{}/{}' references unknown role '{}' (not in [workflow.roles])",
...   |
463 | |                     }
    | |_____________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
454 ~                     if let Some(role) = &stage.role
455 ~                         && !self.roles.contains_key(role) {
456 |                             anyhow::bail!(
...
461 |                             );
462 ~                         }
    |

warning: this `if` statement can be collapsed
   --> zbobr-api/src/config.rs:471:17
    |
471 | /                 if let Some(target) = &stage.call {
472 | |                     if !self.pipelines.contains_key(target.as_str()) {
473 | |                         anyhow::bail!(
474 | |                             "Stage '{}/{}' calls unknown pipeline '{}'",
...   |
480 | |                 }
    | |_________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
471 ~                 if let Some(target) = &stage.call
472 ~                     && !self.pipelines.contains_key(target.as_str()) {
473 |                         anyhow::bail!(
...
478 |                         );
479 ~                     }
    |

warning: this `if` statement can be collapsed
   --> zbobr-api/src/context/mod.rs:333:9
    |
333 | /         if let Some(non_checkbox_idx) = ordered.iter().position(|r| {
334 | |             !matches!(
335 | |                 r.record_type,
336 | |                 MdRecordType::CheckboxUnchecked | MdRecordType::CheckboxChecked
...   |
343 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
338 ~         })
339 ~             && non_checkbox_idx != 0 {
340 |                 let non_checkbox = ordered.remove(non_checkbox_idx);
341 |                 ordered.insert(0, non_checkbox);
342 ~             }
    |

warning: this `if` statement can be collapsed
   --> zbobr-api/src/context/mod.rs:408:13
    |
408 | /             if !link.starts_with("http://") && !link.starts_with("https://") {
409 | |                 if let Some(f) = report_url {
410 | |                     *link = f(link);
411 | |                 }
412 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
408 ~             if !link.starts_with("http://") && !link.starts_with("https://")
409 ~                 && let Some(f) = report_url {
410 |                     *link = f(link);
411 ~                 }
    |

warning: `zbobr-api` (lib) generated 8 warnings (run `cargo clippy --fix --lib -p zbobr-api` to apply 8 suggestions)
    Checking http v1.4.0
    Checking pkcs8 v0.10.2
    Checking zerovec v0.11.5
    Checking http-body v1.0.1
   Compiling cmake v0.1.58
   Compiling fs_extra v1.3.0
   Compiling dunce v1.0.5
    Checking ryu v1.0.23
   Compiling thiserror v2.0.18
   Compiling aws-lc-sys v0.39.1
    Checking tower-service v0.3.3
    Checking hmac v0.12.1
    Checking tinystr v0.8.2
   Compiling ring v0.17.14
    Checking signature v2.2.0
    Checking ff v0.13.1
    Checking writeable v0.6.2
    Checking litemap v0.8.1
    Checking base16ct v0.2.0
    Checking try-lock v0.2.5
   Compiling aws-lc-rs v1.16.2
    Checking bitflags v2.11.0
    Checking want v0.3.1
    Checking sec1 v0.7.3
    Checking icu_locale_core v2.1.1
    Checking group v0.13.0
    Checking zerocopy v0.8.48
    Checking httparse v1.10.1
    Checking hkdf v0.12.4
    Checking zerotrie v0.2.3
    Checking potential_utf v0.1.4
    Checking crypto-bigint v0.5.5
    Checking num-integer v0.1.46
    Checking pin-utils v0.1.0
    Checking cpufeatures v0.2.17
   Compiling getrandom v0.4.2
    Checking atomic-waker v1.1.2
    Checking httpdate v1.0.3
   Compiling ident_case v1.0.1
    Checking spin v0.9.8
    Checking rand_core v0.10.0
    Checking lazy_static v1.5.0
    Checking hyper v1.8.1
    Checking elliptic-curve v0.13.8
    Checking icu_collections v2.1.1
    Checking icu_provider v2.1.1
    Checking ppv-lite86 v0.2.21
    Checking http-body-util v0.1.3
    Checking tokio-util v0.7.18
    Checking rustls-pki-types v1.14.0
    Checking tower-layer v0.3.3
    Checking untrusted v0.9.0
    Checking sync_wrapper v1.0.2
    Checking percent-encoding v2.3.2
    Checking form_urlencoded v1.2.2
    Checking rand_chacha v0.3.1
    Checking hyper-util v0.1.20
    Checking icu_normalizer_data v2.1.1
    Checking icu_properties_data v2.1.2
    Checking sha2 v0.10.9
    Checking rfc6979 v0.4.0
    Checking futures-executor v0.3.32
    Checking powerfmt v0.2.0
   Compiling time-core v0.1.8
    Checking base64 v0.22.1
   Compiling rustls v0.23.37
   Compiling num-conv v0.2.1
   Compiling time-macros v0.2.27
    Checking deranged v0.5.8
    Checking ecdsa v0.16.9
    Checking icu_properties v2.1.2
    Checking icu_normalizer v2.1.1
    Checking rand v0.8.5
    Checking tower v0.5.3
    Checking primeorder v0.13.6
    Checking num-iter v0.1.45
    Checking time v0.3.47
    Checking curve25519-dalek v4.1.3
   Compiling cargo_metadata v0.23.1
    Checking num-bigint-dig v0.8.6
    Checking idna_adapter v1.2.1
    Checking futures v0.3.32
    Checking serde_urlencoded v0.7.1
    Checking num-bigint v0.4.6
    Checking ed25519 v2.2.3
    Checking pkcs1 v0.7.5
    Checking serde_path_to_error v0.1.20
    Checking utf8_iter v1.0.4
    Checking unsafe-libyaml v0.2.11
    Checking openssl-probe v0.2.1
    Checking rustls-native-certs v0.8.3
    Checking serde_yaml v0.9.34+deprecated
    Checking idna v1.1.0
    Checking rsa v0.9.10
    Checking ed25519-dalek v2.2.0
    Checking simple_asn1 v0.6.4
   Compiling octocrab v0.49.6
    Checking p384 v0.13.1
    Checking p256 v0.13.2
    Checking pem v3.0.6
    Checking iri-string v0.7.11
   Compiling fnv v1.0.7
   Compiling darling_core v0.21.3
    Checking tower-http v0.6.8
    Checking pin-project v1.1.11
    Checking snafu v0.8.9
    Checking jsonwebtoken v10.3.0
    Checking arc-swap v1.9.0
    Checking url v2.5.8
    Checking hyper-timeout v0.5.2
   Compiling darling_core v0.23.0
    Checking secrecy v0.10.3
   Compiling rustix v1.1.4
    Checking either v1.15.0
    Checking web-time v1.1.0
   Compiling darling_macro v0.23.0
   Compiling darling_macro v0.21.3
    Checking linux-raw-sys v0.12.1
    Checking cpufeatures v0.3.0
    Checking chacha20 v0.10.0
   Compiling darling v0.21.3
   Compiling darling v0.23.0
    Checking winnow v0.7.15
   Compiling rmcp v0.17.0
    Checking winnow v1.0.0
    Checking mime v0.3.17
    Checking fastrand v2.3.0
    Checking tempfile v3.27.0
    Checking axum-core v0.5.6
    Checking toml_parser v1.1.0+spec-1.1.0
   Compiling rmcp-macros v0.17.0
   Compiling typesafe_builder_derive v1.6.0
    Checking rand v0.10.0
    Checking uuid v1.23.0
    Checking sse-stream v0.2.1
    Checking tokio-stream v0.1.18
    Checking toml_datetime v0.7.5+spec-1.1.0
    Checking serde_spanned v1.1.0
    Checking toml_writer v1.1.0+spec-1.1.0
    Checking matchit v0.8.4
   Compiling pastey v0.2.1
    Checking axum v0.8.8
    Checking toml v0.9.12+spec-1.1.0
    Checking typesafe_builder v1.6.0
    Checking zbobr-repo-backend-fs v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-repo-backend-fs)
    Checking zbobr-task-backend-fs v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-task-backend-fs)
warning: this `if` statement can be collapsed
   --> zbobr-task-backend-fs/src/fs.rs:306:13
    |
306 | /             if let Some(filename) = path.file_name().and_then(|n| n.to_str()) {
307 | |                 if filename.ends_with(".yaml")
308 | |                     && !filename.contains(".comments.")
309 | |                     && let Some(id_str) = filename.strip_suffix(".yaml")
...   |
314 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
    = note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
    |
306 ~             if let Some(filename) = path.file_name().and_then(|n| n.to_str())
307 ~                 && filename.ends_with(".yaml")
308 |                     && !filename.contains(".comments.")
...
312 |                     task_ids.push(id);
313 ~                 }
    |

warning: `zbobr-task-backend-fs` (lib) generated 1 warning (run `cargo clippy --fix --lib -p zbobr-task-backend-fs` to apply 1 suggestion)
    Checking zbobr-executor-claude v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-executor-claude)
    Checking zbobr-executor-mcp-tester v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-executor-mcp-tester)
    Checking zbobr-executor-copilot v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-executor-copilot)
    Checking hostname v0.4.2
    Checking simpleinterpolation v0.2.2
    Checking sdd v3.0.10
    Checking regex-syntax v0.8.10
    Checking unicode-ident v1.0.24
    Checking proc-macro2 v1.0.106
    Checking regex-automata v0.4.14
    Checking scc v2.4.0
    Checking zbobr-dispatcher v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-dispatcher)
    Checking rustls-webpki v0.103.10
warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> zbobr-dispatcher/src/cli.rs:340:21
    |
340 |                     &self.zbobr,
    |                     ^^^^^^^^^^^ help: change this to: `self.zbobr`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

warning: this function has too many arguments (10/7)
    --> zbobr-dispatcher/src/cli.rs:1394:1
     |
1394 | / async fn start_mcp_server(
1395 | |     zbobr: Arc<ZbobrDispatcher>,
1396 | |     role_name: &str,
1397 | |     task_id: u64,
...    |
1404 | |     pipeline_run_id: u64,
1405 | | ) -> anyhow::Result<(u16, tokio::task::JoinHandle<()>)> {
     | |_______________________________________________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_arguments
     = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: this `if` statement can be collapsed
  --> zbobr-dispatcher/src/mcp/common.rs:69:5
   |
69 | /     if let Some(n_str) = id.strip_prefix("ctx_rec_") {
70 | |         if let Ok(n) = n_str.parse::<u64>() {
71 | |             return Ok(n);
72 | |         }
73 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
   = note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
   |
69 ~     if let Some(n_str) = id.strip_prefix("ctx_rec_")
70 ~         && let Ok(n) = n_str.parse::<u64>() {
71 |             return Ok(n);
72 ~         }
   |

warning: this function has too many arguments (10/7)
   --> zbobr-dispatcher/src/mcp/common.rs:154:1
    |
154 | / pub async fn run_role_mcp_server(
155 | |     zbobr: std::sync::Arc<ZbobrDispatcher>,
156 | |     role_name: &str,
157 | |     task_id: u64,
...   |
164 | |     pipeline_run_id: u64,
165 | | ) -> anyhow::Result<u16> {
    | |________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_arguments

warning: this `if` statement can be collapsed
   --> zbobr-dispatcher/src/mcp/traits.rs:392:9
    |
392 | /         if add_context_record {
393 | |             if let Err(e) = self
394 | |                 .session()
395 | |                 .add_context_record(
...   |
415 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
392 ~         if add_context_record
393 ~             && let Err(e) = self
394 |                 .session()
...
413 |                 return response;
414 ~             }
    |

warning: this function has too many arguments (8/7)
  --> zbobr-dispatcher/src/mcp/unified.rs:78:5
   |
78 | /     pub fn new(
79 | |         session: RoleSession,
80 | |         allowed_tools: HashSet<McpTool>,
81 | |         role_name: String,
...  |
86 | |         pipeline_run_id: u64,
87 | |     ) -> Self {
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_arguments

warning: useless conversion to the same type: `rmcp::ErrorData`
   --> zbobr-dispatcher/src/mcp/unified.rs:240:41
    |
240 |           self.tool_router.call(tcc).await.map_err(McpError::from)
    |  _________________________________________-^^^^^^^^^^^^^^^^^^^^^^^
241 | |     }
    | |____- help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

warning: this `if` statement can be collapsed
   --> zbobr-dispatcher/src/prompts.rs:103:12
    |
103 |       } else if let Some(role_def) = stage_def
    |  ____________^
104 | |         .role_name()
105 | |         .and_then(|r| workflow.role_definition(r))
...   |
110 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
105 ~         .and_then(|r| workflow.role_definition(r))
106 ~         && let Some(ref prompt_path) = role_def.prompt {
107 |             files.push(prompt_path.clone());
108 ~         }
    |

warning: this `if` statement can be collapsed
   --> zbobr-dispatcher/src/task.rs:300:13
    |
300 | /             if let Some((_, record)) = task.context.find_record_mut(record_id) {
301 | |                 if let ContextRecordType::Checkbox(_) = record.record_type {
302 | |                     record.record_type = ContextRecordType::Checkbox(true);
303 | |                 }
304 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
300 ~             if let Some((_, record)) = task.context.find_record_mut(record_id)
301 ~                 && let ContextRecordType::Checkbox(_) = record.record_type {
302 |                     record.record_type = ContextRecordType::Checkbox(true);
303 ~                 }
    |

warning: `zbobr-dispatcher` (lib) generated 9 warnings (run `cargo clippy --fix --lib -p zbobr-dispatcher` to apply 6 suggestions)
   Compiling serial_test_derive v3.4.0
    Checking serial_test v3.4.0
    Checking matchers v0.2.0
    Checking quote v1.0.45
    Checking sharded-slab v0.1.7
    Checking tokio-rustls v0.26.4
    Checking hyper-rustls v0.27.7
    Checking toml_datetime v0.6.11
    Checking serde_spanned v0.6.9
    Checking tracing-log v0.2.0
    Checking thread_local v1.1.9
    Checking nu-ansi-term v0.50.3
    Checking toml_write v0.1.2
    Checking toml_edit v0.22.27
    Checking tracing-subscriber v0.3.23
    Checking syn v2.0.117
    Checking heck v0.4.1
warning: `zbobr-task-backend-fs` (lib test) generated 1 warning (1 duplicate)
warning: this `if` statement can be collapsed
   --> zbobr-api/src/context/mod.rs:807:13
    |
807 | /             if let Some(pos) = orig_stage
808 | |                 .records
809 | |                 .iter()
810 | |                 .position(|r| !matches!(r.record_type, ContextRecordType::Checkbox(_)))
...   |
816 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
    |
810 ~                 .position(|r| !matches!(r.record_type, ContextRecordType::Checkbox(_)))
811 ~                 && pos != 0 {
812 |                     let id = expected_ids.remove(pos);
813 |                     expected_ids.insert(0, id);
814 ~                 }
    |

warning: `zbobr-api` (lib test) generated 9 warnings (8 duplicates) (run `cargo clippy --fix --lib -p zbobr-api --tests` to apply 1 suggestion)
    Checking zbobr-task-backend-github v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-task-backend-github)
    Checking zbobr-repo-backend-github v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr-repo-backend-github)
warning: this `map_or` can be simplified
   --> zbobr-repo-backend-github/src/github.rs:309:31
    |
309 |                 let success = status.as_ref().map_or(false, |s| s.success());
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_map_or
    = note: `#[warn(clippy::unnecessary_map_or)]` on by default
help: use is_ok_and instead
    |
309 -                 let success = status.as_ref().map_or(false, |s| s.success());
309 +                 let success = status.as_ref().is_ok_and(|s| s.success());
    |

warning: `zbobr-repo-backend-github` (lib) generated 1 warning (run `cargo clippy --fix --lib -p zbobr-repo-backend-github` to apply 1 suggestion)
warning: this `if` statement can be collapsed
   --> zbobr-task-backend-github/src/github.rs:648:9
    |
648 | /         if !task.stack.is_empty() {
649 | |             if let Ok(json) = serde_json::to_string(&task.stack) {
650 | |                 params.insert(PARAM_STACK.to_string(), json);
651 | |             }
652 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
    = note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
    |
648 ~         if !task.stack.is_empty()
649 ~             && let Ok(json) = serde_json::to_string(&task.stack) {
650 |                 params.insert(PARAM_STACK.to_string(), json);
651 ~             }
    |

warning: very complex type used. Consider factoring parts into `type` definitions
  --> zbobr-task-backend-github/src/separator.rs:47:6
   |
47 | ) -> Result<(String, HashMap<String, String>, Option<String>, TaskContext)> {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default

warning: `zbobr-task-backend-github` (lib) generated 2 warnings (run `cargo clippy --fix --lib -p zbobr-task-backend-github` to apply 1 suggestion)
warning: function `report_success_scenario` is never used
   --> zbobr-dispatcher/tests/mcp_integration/abstract_scenarios.rs:236:8
    |
236 | pub fn report_success_scenario() -> String {
    |        ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default

warning: `zbobr-dispatcher` (test "integration_github_github") generated 1 warning
warning: `zbobr-repo-backend-github` (lib test) generated 1 warning (1 duplicate)
    Checking zbobr v0.1.0 (/data/home/skynet/zdam/zbobr-dev/workspaces/task-246/zbobr/zbobr)
warning: `zbobr-dispatcher` (test "integration_fs_fs") generated 1 warning (1 duplicate)
warning: this `if` statement can be collapsed
   --> zbobr/src/commands.rs:379:17
    |
379 | /                 if let Some(ref filter) = state_filter {
380 | |                     if task.state != *filter {
381 | |                         continue;
382 | |                     }
383 | |                 }
    | |_________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
    = note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
    |
379 ~                 if let Some(ref filter) = state_filter
380 ~                     && task.state != *filter {
381 |                         continue;
382 ~                     }
    |

warning: redundant field names in struct initialization
   --> zbobr-dispatcher/src/task.rs:786:17
    |
786 |                 state: state,
    |                 ^^^^^^^^^^^^ help: replace it with: `state`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#redundant_field_names
    = note: `#[warn(clippy::redundant_field_names)]` on by default

warning: `zbobr` (bin "zbobr" test) generated 1 warning (run `cargo clippy --fix --bin "zbobr" -p zbobr --tests` to apply 1 suggestion)
warning: `zbobr` (bin "zbobr") generated 1 warning (1 duplicate)
warning: `zbobr-task-backend-github` (lib test) generated 2 warnings (2 duplicates)
warning: `zbobr-dispatcher` (lib test) generated 10 warnings (9 duplicates) (run `cargo clippy --fix --lib -p zbobr-dispatcher --tests` to apply 1 suggestion)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 37s