Merge pull request #30 from mindsdb/primary-varchar

Support length in primary key type

Author: ea-rus

mindsdb_sql_parser/parser.py

@@ -723,6 +723,7 @@ def drop_table(self, p):
     @_('id id',
        'id id DEFAULT id',
        'id id PRIMARY_KEY',
+       'id id LPAREN INTEGER RPAREN PRIMARY_KEY',
        'id id LPAREN INTEGER RPAREN',
        'id id LPAREN INTEGER COMMA INTEGER RPAREN',
        'id id LPAREN INTEGER RPAREN DEFAULT id',

tests/test_base_sql/test_create.py

@@ -130,6 +130,26 @@ def test_create(self):
         assert str(ast).lower() == str(expected_ast).lower()
         assert ast.to_tree() == expected_ast.to_tree()
 
+        sql = f'''
+         CREATE TABLE mydb.Persons(
+            Person varchar(10) PRIMARY KEY not null,
+            name TEXT NULL   
+         )
+        '''
+        ast = parse_sql(sql)
+
+        expected_ast = CreateTable(
+            name=Identifier('mydb.Persons'),
+            columns=[
+                TableColumn(name='Person', type='varchar', length=10, is_primary_key=True, nullable=False),
+                TableColumn(name='name', type='TEXT', nullable=True),
+            ]
+        )
+
+        assert str(ast).lower() == str(expected_ast).lower()
+        assert ast.to_tree() == expected_ast.to_tree()
+
+
         # multiple primary keys
 
         sql = f'''