Skip to content

Commit

Permalink
revert: use previous removeDuplicates to keep entry tag order
Browse files Browse the repository at this point in the history
Refs: 863a5b3
  • Loading branch information
Phantop committed Feb 20, 2025
1 parent 4a77e93 commit 61ce395
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions internal/storage/entry.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"errors"
"fmt"
"log/slog"
"slices"
"strings"
"time"

Expand Down Expand Up @@ -612,9 +611,18 @@ func (s *Storage) UnshareEntry(userID int64, entryID int64) (err error) {
return
}

func removeDuplicates(l []string) []string {
slices.Sort(l)
return slices.Compact(l)
// removeDuplicate removes duplicate entries from a slice while keeping order.
// Some feeds expect tags to be shown in order, so we preserve it rather than sort.
func removeDuplicates[T string | int](sliceList []T) []T {
allKeys := make(map[T]bool)
list := []T{}
for _, item := range sliceList {
if _, value := allKeys[item]; !value {
allKeys[item] = true
list = append(list, item)
}
}
return list
}

func removeEmpty(l []string) []string {
Expand Down

0 comments on commit 61ce395

Please sign in to comment.