diff --git a/internal/reader/rewrite/rewrite_functions.go b/internal/reader/rewrite/rewrite_functions.go index c16349553ce..a696c22a2c7 100644 --- a/internal/reader/rewrite/rewrite_functions.go +++ b/internal/reader/rewrite/rewrite_functions.go @@ -23,7 +23,6 @@ var ( youtubeRegex = regexp.MustCompile(`youtube\.com/watch\?v=(.*)$`) youtubeIdRegex = regexp.MustCompile(`youtube_id"?\s*[:=]\s*"([a-zA-Z0-9_-]{11})"`) invidioRegex = regexp.MustCompile(`https?://(.*)/watch\?v=(.*)`) - imgRegex = regexp.MustCompile(`]+>`) textLinkRegex = regexp.MustCompile(`(?mi)(\bhttps?:\/\/[-A-Z0-9+&@#\/%?=~_|!:,.;]*[-A-Z0-9+&@#\/%=~_|])`) ) @@ -84,10 +83,11 @@ func addMailtoSubject(entryContent string) string { } func addDynamicImage(entryContent string) string { - doc, err := goquery.NewDocumentFromReader(strings.NewReader(entryContent)) + parserHtml, err := nethtml.ParseWithOptions(strings.NewReader(entryContent), nethtml.ParseOptionEnableScripting(false)) if err != nil { return entryContent } + doc := goquery.NewDocumentFromNode(parserHtml) // Ordered most preferred to least preferred. candidateAttrs := []string{ @@ -149,12 +149,9 @@ func addDynamicImage(entryContent string) string { if !changed { doc.Find("noscript").Each(func(i int, noscript *goquery.Selection) { - matches := imgRegex.FindAllString(noscript.Text(), 2) - - if len(matches) == 1 { + if img := noscript.Find("img"); img.Length() == 1 { + img.Unwrap() changed = true - - noscript.ReplaceWithHtml(matches[0]) } }) } diff --git a/internal/reader/rewrite/rewriter_test.go b/internal/reader/rewrite/rewriter_test.go index fa2b765bd2e..93123dbb78e 100644 --- a/internal/reader/rewrite/rewriter_test.go +++ b/internal/reader/rewrite/rewriter_test.go @@ -256,7 +256,7 @@ func TestRewriteWithNoLazyImage(t *testing.T) { func TestRewriteWithLazyImage(t *testing.T) { controlEntry := &model.Entry{ Title: `A title`, - Content: `Image`, + Content: `Image`, } testEntry := &model.Entry{ Title: `A title`, @@ -272,7 +272,7 @@ func TestRewriteWithLazyImage(t *testing.T) { func TestRewriteWithLazyDivImage(t *testing.T) { controlEntry := &model.Entry{ Title: `A title`, - Content: `Image`, + Content: `Image`, } testEntry := &model.Entry{ Title: `A title`,