Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_tables rule breaks content in Switch Weekly #3110

Open
sclu1034 opened this issue Jan 27, 2025 · 4 comments
Open

remove_tables rule breaks content in Switch Weekly #3110

sclu1034 opened this issue Jan 27, 2025 · 4 comments
Labels

Comments

@sclu1034
Copy link

sclu1034 commented Jan 27, 2025

The remove_tables rule is documented as "keeping the content inside".
However, when I try to use it with Switch Weekly, it does remove content. Most notably, the intro text is missing.

I'm using https://kill-the-newsletter.com/ to turn the emails into an RSS feed. The table, including the text, does show up when I remove the rewrite rule.

@fguillot
Copy link
Member

Can you share the feed URL or copy and paste the feed XML content in the GitHub issue?

@sclu1034
Copy link
Author

Feed XML: https://gist.github.com/sclu1034/7eeec68d584374bf3b0c40fbc6fadf3e

Identifiers for kill-the-newsletter have been removed, since they are personalized.

@fguillot
Copy link
Member

However, when I try to use it with Switch Weekly, it does remove content. Most notably, the intro text is missing.

You are referring to the content in the nested table?

After rewrite:

Image

Original:

Image

@sclu1034
Copy link
Author

After finding a way to compare the two versions side-by-side now, I realized that the content doesn't actually get removed completely, but instead re-arranged.

The header above the image, and paragraph from below the image move to the very bottom. The "Upcoming Releases" section gets mixed with "Quick Links".

And because "Upcoming Releases" actually uses tables "normally", it also breaks in such a way that the list isn't grouped by date anymore.


So I guess there are two issues:

  • nested tables don't get inserted where they should be
  • remove_tables needs an optional parameter that allows excluding based on a selector, when a "normal" table needs to be kept

@sclu1034 sclu1034 changed the title remove_tables rule removes content remove_tables rule breaks content in Switch Weekly Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants