Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the redundant page-header-title #3170

Open
jvoisin opened this issue Feb 21, 2025 · 3 comments
Open

Get rid of the redundant page-header-title #3170

jvoisin opened this issue Feb 21, 2025 · 3 comments

Comments

@jvoisin
Copy link
Collaborator

jvoisin commented Feb 21, 2025

The page-header-title is exposing information that is already present in the header-menu. I think it would make sense to get rid of it. The only other change would be to show the number of items in the current category (history/stared/unread/…) there.


Before:

Image

After:

Image


Before:

Image

After:

Image

@xfzv
Copy link

xfzv commented Feb 21, 2025

Good idea! This is redundant and a waste of space in my opinion.

@fguillot
Copy link
Member

fguillot commented Mar 7, 2025

The page header title is useful on some nested pages. For example, if you remove the title from the shared entries page, you won't know whether you are on the history page or the shared entries page.

Image

Also, there are probably some implications regarding web accessibility, but I'm not expert.

@jvoisin
Copy link
Collaborator Author

jvoisin commented Mar 7, 2025

Shared entries should/could be moved to its own top-level item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants