From 0a10632e9613e6b0eb34839683fe44bd0eba6d91 Mon Sep 17 00:00:00 2001
From: krvpb024 <krvpb024@protonmail.com>
Date: Mon, 5 Feb 2024 11:40:11 +0800
Subject: [PATCH 1/2] add button role to links with action

---
 internal/template/templates/views/category_entries.html | 4 +++-
 internal/template/templates/views/category_feeds.html   | 3 ++-
 internal/template/templates/views/entry.html            | 5 +++++
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/internal/template/templates/views/category_entries.html b/internal/template/templates/views/category_entries.html
index 8551eb22e71..d614eda4df4 100644
--- a/internal/template/templates/views/category_entries.html
+++ b/internal/template/templates/views/category_entries.html
@@ -18,6 +18,7 @@ <h1 id="page-header-title" dir="auto">
             {{ if .entries }}
             <li>
                 <a href="#"
+                    role="button"
                     data-action="markPageAsRead"
                     data-label-question="{{ t "confirm.question" }}"
                     data-label-yes="{{ t "confirm.yes" }}"
@@ -27,6 +28,7 @@ <h1 id="page-header-title" dir="auto">
             </li>
             <li>
                 <a href="#"
+                    role="button"
                     data-confirm="true"
                     data-label-question="{{ t "confirm.question" }}"
                     data-label-yes="{{ t "confirm.yes" }}"
@@ -48,7 +50,7 @@ <h1 id="page-header-title" dir="auto">
                 <a href="{{ route "categoryFeeds" "categoryID" .category.ID }}">{{ icon "feeds" }}{{ t "menu.feeds" }}</a>
             </li>
             <li>
-                <a href="{{ route "refreshCategoryEntriesPage" "categoryID" .category.ID }}">{{ icon "refresh" }}{{ t "menu.refresh_all_feeds" }}</a>
+                <a role="button" href="{{ route "refreshCategoryEntriesPage" "categoryID" .category.ID }}">{{ icon "refresh" }}{{ t "menu.refresh_all_feeds" }}</a>
             </li>
         </ul>
     </nav>
diff --git a/internal/template/templates/views/category_feeds.html b/internal/template/templates/views/category_feeds.html
index bcb9a0266a0..fcc88f7a155 100644
--- a/internal/template/templates/views/category_feeds.html
+++ b/internal/template/templates/views/category_feeds.html
@@ -18,6 +18,7 @@ <h1 id="page-header-title" dir="auto">
             {{ if eq .total 0 }}
             <li>
                 <a href="#"
+                    role="button"
                     data-confirm="true"
                     data-label-question="{{ t "confirm.question" }}"
                     data-label-yes="{{ t "confirm.yes" }}"
@@ -28,7 +29,7 @@ <h1 id="page-header-title" dir="auto">
             </li>
             {{ end }}
             <li>
-                <a href="{{ route "refreshCategoryFeedsPage" "categoryID" .category.ID }}">{{ icon "refresh" }}{{ t "menu.refresh_all_feeds" }}</a>
+                <a role="button" href="{{ route "refreshCategoryFeedsPage" "categoryID" .category.ID }}">{{ icon "refresh" }}{{ t "menu.refresh_all_feeds" }}</a>
             </li>
         </ul>
     </nav>
diff --git a/internal/template/templates/views/entry.html b/internal/template/templates/views/entry.html
index 0511af88bc1..ec0bd7478c2 100644
--- a/internal/template/templates/views/entry.html
+++ b/internal/template/templates/views/entry.html
@@ -11,6 +11,7 @@ <h1 id="page-header-title" dir="auto">
             <ul>
                 <li>
                     <a href="#"
+                        role="button"
                         title="{{ t "entry.status.title" }}"
                         data-toggle-status="true"
                         data-label-loading="{{ t "entry.state.saving" }}"
@@ -23,6 +24,7 @@ <h1 id="page-header-title" dir="auto">
                 </li>
                 <li>
                     <a href="#"
+                        role="button"
                         data-toggle-bookmark="true"
                         data-bookmark-url="{{ route "toggleBookmark" "entryID" .entry.ID }}"
                         data-label-loading="{{ t "entry.state.saving" }}"
@@ -36,6 +38,7 @@ <h1 id="page-header-title" dir="auto">
                 {{ if .hasSaveEntry }}
                 <li>
                     <a href="#"
+                        role="button"
                         title="{{ t "entry.save.title" }}"
                         data-save-entry="true"
                         data-save-url="{{ route "saveEntry" "entryID" .entry.ID }}"
@@ -54,6 +57,7 @@ <h1 id="page-header-title" dir="auto">
                 </li>
                 <li>
                     <a href="#"
+                        role="button"
                         data-confirm="true"
                         data-url="{{ route "unshareEntry" "entryID" .entry.ID }}"
                         data-label-question="{{ t "confirm.question" }}"
@@ -78,6 +82,7 @@ <h1 id="page-header-title" dir="auto">
                 </li>
                 <li>
                     <a href="#"
+                        role="button"
                         title="{{ t "entry.scraper.title" }}"
                         data-fetch-content-entry="true"
                         data-fetch-content-url="{{ route "fetchContent" "entryID" .entry.ID }}"

From 2d17c7c6e6ee08ba83b06593fee35f80dc4b4c22 Mon Sep 17 00:00:00 2001
From: krvpb024 <krvpb024@protonmail.com>
Date: Mon, 5 Feb 2024 13:19:52 +0800
Subject: [PATCH 2/2] remove button role on element which perform navigation

---
 internal/template/templates/common/feed_list.html | 2 --
 internal/template/templates/common/item_meta.html | 2 --
 2 files changed, 4 deletions(-)

diff --git a/internal/template/templates/common/feed_list.html b/internal/template/templates/common/feed_list.html
index d293596a1fc..5ff37c0afe3 100644
--- a/internal/template/templates/common/feed_list.html
+++ b/internal/template/templates/common/feed_list.html
@@ -51,12 +51,10 @@ <h2 id="feed-title-{{ .ID }}" class="item-title">
                 <ul class="item-meta-icons">
                     <li class="item-meta-icons-refresh">
                         <a href="{{ route "refreshFeed" "feedID" .ID }}"
-                            role="button"
                             aria-describedby="feed-title-{{ .ID }}">{{ icon "refresh" }}<span class="icon-label">{{ t "menu.refresh_feed" }}</span></a>
                     </li>
                     <li class="item-meta-icons-edit">
                         <a href="{{ route "editFeed" "feedID" .ID }}"
-                            role="button"
                             aria-describedby="feed-title-{{ .ID }}">{{ icon "edit" }}<span class="icon-label">{{ t "menu.edit_feed" }}</span></a>
                     </li>
                     <li class="item-meta-icons-remove">
diff --git a/internal/template/templates/common/item_meta.html b/internal/template/templates/common/item_meta.html
index bb4dee3acdd..8d48c98346b 100644
--- a/internal/template/templates/common/item_meta.html
+++ b/internal/template/templates/common/item_meta.html
@@ -75,7 +75,6 @@
         {{ end }}
         <li class="item-meta-icons-external-url">
             <a href="{{ .entry.URL | safeURL  }}"
-                role="button"
                 aria-describedby="entry-title-{{ .entry.ID }}"
                 target="_blank"
                 rel="noopener noreferrer"
@@ -85,7 +84,6 @@
         {{ if .entry.CommentsURL }}
             <li class="item-meta-icons-comments">
                 <a href="{{ .entry.CommentsURL | safeURL  }}"
-                    role="button"
                     aria-describedby="entry-title-{{ .entry.ID }}"
                     title="{{ t "entry.comments.title" }}"
                     target="_blank"