fix GetBucketVersioning XML parsing (#181)

balamurugana · web-flow · commit 5a5533e4d547 · 2024-12-19T23:52:24.000+05:30
Fixes #180 Signed-off-by: Bala.FA <bala@minio.io>
diff --git a/src/baseclient.cc b/src/baseclient.cc
@@ -854,11 +854,11 @@ GetBucketVersioningResponse BaseClient::GetBucketVersioning(
 
   pugi::xpath_node text;
 
-  if (!root.node().select_node("Status")) {
+  if (root.node().select_node("Status")) {
     text = root.node().select_node("Status/text()");
     response.status = (strcmp(text.node().value(), "Enabled") == 0);
   }
-  if (!root.node().select_node("MFADelete")) {
+  if (root.node().select_node("MFADelete")) {
     text = root.node().select_node("MFADelete/text()");
     response.mfa_delete = (strcmp(text.node().value(), "Enabled") == 0);
   }

Original file line number	Diff line number	Diff line change
`@@ -854,11 +854,11 @@ GetBucketVersioningResponse BaseClient::GetBucketVersioning(`
`854`	`854`
`855`	`855`	`pugi::xpath_node text;`
`856`	`856`
`857`		`- if (!root.node().select_node("Status")) {`
	`857`	`+ if (root.node().select_node("Status")) {`
`858`	`858`	`text = root.node().select_node("Status/text()");`
`859`	`859`	`response.status = (strcmp(text.node().value(), "Enabled") == 0);`
`860`	`860`	`}`
`861`		`- if (!root.node().select_node("MFADelete")) {`
	`861`	`+ if (root.node().select_node("MFADelete")) {`
`862`	`862`	`text = root.node().select_node("MFADelete/text()");`
`863`	`863`	`response.mfa_delete = (strcmp(text.node().value(), "Enabled") == 0);`
`864`	`864`	`}`