Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py.toml changes are breaking faas commands #71

Open
charlieparkes opened this issue Dec 7, 2020 · 3 comments
Open

py.toml changes are breaking faas commands #71

charlieparkes opened this issue Dec 7, 2020 · 3 comments

Comments

@charlieparkes
Copy link

cd /home/travis/build/alphachai/boto3-fixtures/dummy_lambda/dist && zip build.zip pyproject.toml

	zip warning: name not matched: pyproject.toml

zip error: Nothing to do! (build.zip)

/home/travis/build/alphachai/boto3-fixtures/build-harness/modules/faas/Makefile:38: recipe for target 'faas/build/python/zip' failed

make[1]: *** [faas/build/python/zip] Error 12

Lack of a pyproject.toml breaks faas/build/python/zip.

@charlieparkes
Copy link
Author

@aspage2

@aspage2
Copy link
Member

aspage2 commented Dec 7, 2020

What should the expected behavior here be? Initial thought would be to swallow the error and just create build.zip without a pyproject.toml:

faas/build/python/zip:
    ....
    cd $(FAAS_BUILD_DIST) && (zip build.zip pyproject.toml || true)
    ....

@charlieparkes
Copy link
Author

Yeah, I think that would work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants