Skip to content

Commit b10311e

Browse files
authored
Merge pull request getsentry#627 from chulkilee/log-once
log backtrace at once
2 parents 8b89e84 + 7ee9555 commit b10311e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/raven/client.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,7 @@ def successful_send
9797
def failed_send(e, event)
9898
@state.failure
9999
if e # exception was raised
100-
configuration.logger.error "Unable to record event with remote Sentry server (#{e.class} - #{e.message})"
101-
e.backtrace[0..10].each { |line| configuration.logger.error(line) }
100+
configuration.logger.error "Unable to record event with remote Sentry server (#{e.class} - #{e.message}):\n#{e.backtrace[0..10].join("\n")}"
102101
else
103102
configuration.logger.error "Not sending event due to previous failure(s)."
104103
end

spec/raven/integration_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@
4848
config.logger = logger
4949
end
5050

51-
expect(logger).to receive(:error).at_least(10).times
51+
# sentry error and original error
52+
expect(logger).not_to receive(:error).twice
5253
Raven.capture_exception(build_exception)
5354

5455
stubs.verify_stubbed_calls

0 commit comments

Comments
 (0)