make sure storage account and vault name are unique, add notes about cef 69), make more params on az_create rather than hardcoded values

Author: mitchcapper

AzureTemplateParams.json

@@ -41,12 +41,6 @@
         "osDiskType": {
             "value": "Premium_LRS"
         },
-        "diagnosticsStorageAccountName": {
-            "value": "estdiag862"
-        },
-        "diagnosticsStorageAccountId": {
-            "value": "Microsoft.Storage/storageAccounts/estdiag862"
-        },
         "diagnosticsStorageAccountType": {
             "value": "Standard_LRS"
         },

README.md

@@ -26,7 +26,7 @@
 ## Summary
 Automated chrome cef building and/or cefsharp building dockerfiles and scripts.
 
-While the processes of building CEF and CEFSHARP are not hard they require a very exacting environment and build steps can take a _long_ time so are annoying to repeat.  The goal if this repo is a collection of scripts to automate everything to make it easy for anyone to do.  We are using Docker to run everything in a container as it makes it much easier to reproduce and won't pollute your dev environment with all the pre-reqs.  You can easily tweak the exact versions you want to build, and the build flags.  From creating a VM on your cloud provider of choice (or your own machine) it is about 20 minutes of setup, starting a build script, and just waiting a few hours for it to spit out the compiled binaries.  It has been tested with 63, 65, and 67 but would likely work for any modern chrome build without changes (in most cases).
+While the processes of building CEF and CEFSHARP are not hard they require a very exacting environment and build steps can take a _long_ time so are annoying to repeat.  The goal if this repo is a collection of scripts to automate everything to make it easy for anyone to do.  We are using Docker to run everything in a container as it makes it much easier to reproduce and won't pollute your dev environment with all the pre-reqs.  You can easily tweak the exact versions you want to build, and the build flags.  From creating a VM on your cloud provider of choice (or your own machine) it is about 20 minutes of setup, starting a build script, and just waiting a few hours for it to spit out the compiled binaries.  It has been tested with 63, 65, 67, and 69 but would likely work for any modern chrome build without changes (in most cases).
 
 
 ## Thanks
@@ -45,7 +45,7 @@ In part we use the latest version of several installers/build tools if they chan
 Window 10 Client (Pro) by default with docker uses HyperV isolation, this mode is very non performant vs process isolation mode.
 
 ## Requirements
-The following requirements are for chrome 63(and more or less 65 and 67) and the current vs_2017 installer, they may change over time.  Compiling is largely CPU bound but linking is largely IO bound.
+The following requirements are for chrome 63(and more or less 65, 67 and 69) and the current vs_2017 installer, they may change over time.  Compiling is largely CPU bound but linking is largely IO bound.
 
 - At least 20GB of ram dedicated to this would recommend 30GB total with page file to make sure you don't run out (older builds like 63 were 32GB with 40GB total).  You can have any amount of that 20/30GB as a page file, just beware the less actual ram the much slower linking will be.
 - At least 250GB of space.
@@ -136,8 +136,8 @@ You could also expose the docker server to the internet and use remote docker co
 
 ### Estimated time requirements
 With the Azure F32 v2 host above the total estimated build time is about 2.1 hours (~$6 on azure). Machines are nice 600MB/sec read/write to the local disk.  The time could be cut close to in half if you used a F64 v2 VM, but your cost will remain the same (as its twice the price for twice the power).  Note it can vary somewhat dramatically for the not cef build steps based on the luck of the draw (but the cef build is most of the build time).  It seems local IO depending on what physical host it is spun up on can cause 30-50% performance fluxes.  Most of the build steps make efficient use of the machine however: The git cloning is not very efficient. It is 30 minutes of the cef build time below. It doesn't quite max out network or IO. The linking stage is also not super efficient see the DUAL_BUILD flag below to help with that. Linking will take 20+ minutes per platform (40 total unless run concurrently).  Here are the individual build/commit times:
-- pull source image: 5 minutes
-- vs: 11 minutes
+- pull source image: 3 minutes
+- vs: 15 minutes
 - cef: 1.8 hours (with DUAL_BUILD)
 - cef-binary: 3 minutes
 - cefsharp: 4 minutes

az_create.ps1

@@ -2,18 +2,25 @@
 Param(
 	[Parameter(Mandatory=$true)]
 	[PSCredential] $admin_creds,
-	[String] $shutdown_email
+	[String] $shutdown_email,
+	[String] $RESOURCE_GROUP="CEFTest",
+	[String] $LOCATION="West US 2",
+	[String] $MACHINE_SIZE="Standard_F72s_v2",
+	[String] $SHUTDOWN_TIME="23:30",
+	[String] $RANDOM_STR=""
+
 )	
 Set-StrictMode -version latest
 $ErrorActionPreference = "Stop";
-$VAULT_NAME = "CEFVault"
-$RESOURCE_GROUP = "CEFTest"
-$LOCATION="West US 2"
-$MACHINE_SIZE="Standard_F32s_v2"
+$rand_str = $RANDOM_STR;
+if (! $rand_str){
+	$rand_str = -join ((97..122) | Get-Random -Count 5 | % {[char]$_});
+}
+$VAULT_NAME = "CEFVault-" + $rand_str;
 $SECRET_NAME="CEFPSCertSecret"
 $CERT_PASS="dummy"
-$SHUTDOWN_TIME="23:30";
 $SHUTDOWN_TIMEZONE="Pacific Standard Time";
+$DIAG_STORAGE_ACT="estdiag86" + $rand_str;
 Function WriteException($exp){
 	write-host "Caught an exception:" -ForegroundColor Yellow -NoNewline
 	write-host " $($exp.Exception.Message)" -ForegroundColor Red
@@ -25,7 +32,7 @@ Function WriteException($exp){
 
 try{
 
-
+Write-Host "RANDOM_STR FOR THIS SESSION: $RANDOM_STR"
 $CERT_PASS_SEC=ConvertTo-SecureString -AsPlainText -Force $CERT_PASS
 $cred = $admin_creds
 #Connect-AzureRmAccount
@@ -49,7 +56,7 @@ else{
 
 $vault = Get-AzureRmKeyVault -VaultName $VAULT_NAME -ErrorAction SilentlyContinue
 if (! $vault){
-	Write-Host "Creating key vault to store remote powershell certificate in"
+	Write-Host "Creating key vault to store remote powershell certificate in: $VAULT_NAME"
 	New-AzureRmKeyVault -VaultName $VAULT_NAME -ResourceGroupName $RESOURCE_GROUP -Location $LOCATION -EnabledForDeployment -EnabledForTemplateDeployment | Out-Null
 	$vault = Get-AzureRmKeyVault -VaultName $VAULT_NAME
 }else{
@@ -100,6 +107,8 @@ $hashtable.PsRemoteSecretUrl = $secretURL;
 $hashtable.adminUsername = $cred.UserName;
 $hashtable.adminPassword = $cred.Password;
 $hashtable.location = $LOCATION;
+$hashtable.diagnosticsStorageAccountName = $DIAG_STORAGE_ACT;
+$hashtable.diagnosticsStorageAccountId = "Microsoft.Storage/storageAccounts/" + $DIAG_STORAGE_ACT;
 $hashtable.virtualMachineSize = $MACHINE_SIZE;
 $hashtable.autoShutdownTimeZone = $SHUTDOWN_TIMEZONE;
 $hashtable.autoShutdownTime = $SHUTDOWN_TIME;