Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick one: Lodash or Ramda and import modularly #48

Open
2 tasks
ChristopherChudzicki opened this issue Jan 17, 2023 · 0 comments
Open
2 tasks

Pick one: Lodash or Ramda and import modularly #48

ChristopherChudzicki opened this issue Jan 17, 2023 · 0 comments

Comments

@ChristopherChudzicki
Copy link
Contributor

Since this project is being used in OCW we are interested in trimming its size.

Currently, all of lodash is being included in OCW because of its dependency here. (Admittedly, that's arguably a treeshaking issue on OCW's side). Additionally, this project is including both lodash and ramda which overlap heavily. So let's pick one.

Acceptance Criteria

  • do not include both lodash and ramda
  • use modular imports ("lodash/cloneDeep" or "ramda/src/whatever" rather than including the whole library
@ChristopherChudzicki ChristopherChudzicki changed the title Drop lodash and/or ramda Pick one: Lodash or Ramda, import modularly Jan 17, 2023
@ChristopherChudzicki ChristopherChudzicki changed the title Pick one: Lodash or Ramda, import modularly Pick one: Lodash or Ramda and import modularly Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChristopherChudzicki