call user_created plugin method for SCIM users (#2387)

* fixing test and using plugin directly

* refactor

* pass in empty dict to profile create

Author: shanbady

users/adapters.py

@@ -1,6 +1,6 @@
 from mitol.scim.adapters import UserAdapter
 
-from authentication.api import user_created_actions
+from authentication.hooks import get_plugin_manager
 from profiles.models import Profile
 
 
@@ -40,13 +40,23 @@ def from_dict(self, d):
         self.obj.profile.name = d.get("fullName", d.get("name", ""))
         self.obj.profile.email_optin = d.get("emailOptIn", 1) == 1
 
+    def save(self):
+        """
+        Save the user object and any related objects, such as the profile.
+        """
+        newly_created = self.is_new_user
+        super().save()
+        if newly_created:
+            pm = get_plugin_manager()
+            hook = pm.hook
+            hook.user_created(user=self.obj, user_data={})
+
     def _save_related(self):
         """
         Save models related to the user
         """
         self.obj.profile.user = self.obj
         self.obj.profile.save()
-        user_created_actions(user=self.obj, details=self.to_dict(), is_new=True)
 
     def _handle_replace_nested_path(self, nested_path, nested_value):
         """Per-path replacement handling"""

users/adapters_test.py

@@ -11,8 +11,12 @@ def test_save_related_creates_profile_and_favorites_if_missing(mocker, settings)
     Test that saving a LearnUserAdapter creates a profile and default favorites list
     """
     settings.MITOL_AUTHENTICATION_PLUGINS = "learning_resources.plugins.FavoritesListPlugin,profiles.plugins.CreateProfilePlugin"
-    user = UserFactory()
 
+    # simulate a new and blank unsaved user
+    user = UserFactory.create()
+    user.scim_id = None
+    user.global_id = None
+    user.id = None
     scimUser = LearnUserAdapter(user)
     scimUser.request = RequestFactory()
     scimUser.obj.request = RequestFactory()