Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comparator from framework #17

Open
tbostic32 opened this issue Nov 16, 2020 · 1 comment
Open

Remove comparator from framework #17

tbostic32 opened this issue Nov 16, 2020 · 1 comment

Comments

@tbostic32
Copy link
Collaborator

tbostic32 commented Nov 16, 2020

With the addition of @jstanley-mitre templating solution (see docs/template.md), this makes the comparator vestigial (at least for the web interface). Unless there is a use for it, we should consider removing it from the framework.

On the other hand, the comparator could be useful with other interfaces besides web, so maybe it doesn't make sense to remove/detangle it from the framework just yet.

@jstanley-mitre
Copy link
Collaborator

If we want to keep the comparator, we could fit the templating solution into its own comparator class. This would allow others to come up with their own custom comparing solutions and easily attach them to the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants