refactor: Improve clarity of ConfigError variants #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstepanian
force-pushed
the
cstepanian/config_error
branch
3 times, most recently
from
2875c9e to
f864c0f
Compare
j-lanson
requested changes
Feb 19, 2025
|
@alilleybrinker tagging you to take a look at this since we can't walk back changes to the protocol definition once added. |
cstepanian
force-pushed
the
cstepanian/config_error
branch
2 times, most recently
from
2836d05 to
1806751
Compare
j-lanson
requested changes
Feb 19, 2025
cstepanian
force-pushed
the
cstepanian/config_error
branch
from
1806751 to
4204d68
Compare
cstepanian
force-pushed
the
cstepanian/config_error
branch
from
4204d68 to
92241d9
Compare
j-lanson
requested changes
Feb 19, 2025
Resolves #931 Add new variants to replace all existing uses of `Unspecified`, other than `serde_json` parse errors: - `InternalError` - `FileNotFound` - `ParseError` - `EnvVarNotSet` - `MissingProgram` Signed-off-by: Cal Stepanian <[email protected]>
cstepanian
force-pushed
the
cstepanian/config_error
branch
from
92241d9 to
69efa8c
Compare
…r display Signed-off-by: jlanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #931
Add new variants to replace all existing uses of
Unspecified, other thanserde_jsonparse errors:InternalErrorFileNotFoundParseErrorEnvVarNotSetMissingProgram