Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect name reference to service account name in helm cluster role binding template #344

Closed
jaythamke opened this issue Aug 1, 2024 · 1 comment
Labels

Comments

@jaythamke
Copy link
Contributor

jaythamke commented Aug 1, 2024

Describe the bug
Cluster role binding template (templates/rbac.yaml) references an incorrect value (helm chart release name) for the service account name - here.

To Reproduce

Execute following command -

helm template \
  kubernetes-replicator mittwald/kubernetes-replicator \
  --create-namespace \
  --namespace kubernetes-replicator \
  --version 2.10.0 \
  --set serviceAccount.name=resource-replicator | grep -A3 "subjects:"

Output:

subjects:
  - kind: ServiceAccount
    name: kubernetes-replicator
    namespace: "kubernetes-replicator"

The service account name in subjects in cluster role binding is incorrect. It should be resource-replicator

Expected behavior
The service account name in subjects in cluster role binding should be resource-replicator.

Environment:

  • Kubernetes version: v1.30.1
  • kubernetes-replicator version: v2.10.0
@jaythamke
Copy link
Contributor Author

Please see the PR (fix) - #345

@Lucaber Lucaber closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants