Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to release a new version? #29

Open
alexrkopp opened this issue Apr 20, 2020 · 2 comments
Open

Plans to release a new version? #29

alexrkopp opened this issue Apr 20, 2020 · 2 comments

Comments

@alexrkopp
Copy link

Hello,

It looks like there are some changes in the master branch that have been there for several months (namely the hasMetrics and shutdown methods). Are there plans to release this in the near future?

Thanks!

@andybryant
Copy link

Using the latest unreleased version from a lambda - I noticed the shutdown method is incomplete - it needs to shutdown the summaryInterval too:

Metric.prototype.shutdown = function() {
  clearInterval(this._interval);
  this._sendMetrics();

  clearInterval(this._summaryInterval);
  this._summarizeMetrics();
};

@Nevon
Copy link
Contributor

Nevon commented Oct 12, 2020

I ran into this as well, as I had written Typescript definitions based on master which didn't match what was in the latest version. Would be very nice to get a new release so that I don't have to depend on my fork.

@andybryant: #34 fixes the issue with the shutdown method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants