Skip to content

Commit 5421a7c

Browse files
committed
rn-66: some minor fixes
1 parent e39b0ed commit 5421a7c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

rev_news/drafts/edition-66.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ This edition covers what happened during the month of July 2020.
114114
115115
The syntax was explained by Jeff King, alias Peff, who also said that the
116116
short option `-P` had to be spelled `--perl-regexp` before Git version
117-
v2.14.0. He also reminded that for this to work one also need a version of Git
117+
v2.14.0. He also reminded that for this to work one also needs a version of Git
118118
built with libpcre support.
119119

120120
It turned out however that it [didn't resolve](https://public-inbox.org/git/CAAvDm6Z6SA8rYYHaFT=APBSx0tM+5rHseP+fRLufgDxvEthsww@mail.gmail.com/)
@@ -132,7 +132,7 @@ This edition covers what happened during the month of July 2020.
132132
>
133133
> comments 2020.04.12 ng
134134
135-
Peff responded that he can't think of a way to do what you want just a regex,
135+
Peff responded that he can't think of a way to achieve that just using a regex,
136136
and that currently [Git supports similar feature only in `git grep`](https://public-inbox.org/git/[email protected]/):
137137

138138
> The natural thing to me would be the equivalent of:
@@ -148,11 +148,11 @@ This edition covers what happened during the month of July 2020.
148148
> (certainly one complication is that "--not" already means something else
149149
> there, but presumably we could have "--grep-and", "--grep-not", etc).
150150
151-
The idea of `--grep-and` and `--grep-not` to disambiguate the `--not` (which
151+
The idea of introducing `--grep-and` and `--grep-not` to disambiguate from `--not` (which
152152
means something completely different for the log family) is
153153
[as old as 2012](https://lore.kernel.org/git/[email protected]/),
154154
as Junio C Hamano reminded. He then went to [explain the problem](https://public-inbox.org/git/[email protected]/)
155-
with properly implemeting such feature:
155+
with properly implementing such feature:
156156

157157
> Having said that, I do not think our underlying grep machinery is
158158
> equipped to answer "find every commit whose log message has X but

0 commit comments

Comments
 (0)