From 46e2169c9f3daf300581083dbd96f3b0e01a5668 Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Fri, 3 Apr 2020 09:40:25 +0200 Subject: [PATCH] Fix comparison between pointer and zero character constant. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix #44 See, libzbxsystemd.c: In function ‘SYSTEMD_UNIT_DISCOVERY’: libzbxsystemd.c:214:35: warning: comparison between pointer and zero character constant [-Wpointer-compare] 214 | if(NULL != filter || '\0' != filter) | ^~ libzbxsystemd.c:214:38: note: did you mean to dereference the pointer? 214 | if(NULL != filter || '\0' != filter) | Signed-off-by: Mario Trangoni --- src/modules/systemd/libzbxsystemd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/systemd/libzbxsystemd.c b/src/modules/systemd/libzbxsystemd.c index c24a034..dc72fed 100644 --- a/src/modules/systemd/libzbxsystemd.c +++ b/src/modules/systemd/libzbxsystemd.c @@ -211,8 +211,8 @@ static int SYSTEMD_UNIT_DISCOVERY(AGENT_REQUEST *request, AGENT_RESULT *result) switch (i) { case 0: // filter by unit type - if(NULL != filter || '\0' != filter) - if(0 == systemd_cmptype(value.str, filter)) + if(NULL != filter && '\0' != *filter) + if (0 == systemd_cmptype(value.str, filter)) goto next_unit; zbx_json_addobject(&j, NULL);