Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of R dependency list does not reorder for indirect dependencies #2

Open
mlell opened this issue May 30, 2021 · 0 comments
Open

Creation of R dependency list does not reorder for indirect dependencies #2

mlell opened this issue May 30, 2021 · 0 comments

Comments

@mlell
Copy link
Owner

mlell commented May 30, 2021

Currently, R packages extracted from their code are reordered so that each package is installed after its direct dependencies.

tapas/scripts/gen/scan_r_dependencies.R

Lines 10 to 11 in 6d7e273

deps <- tools::package_dependencies(p, recursive = TRUE)
deps <- lapply(deps, rev) # Dependencies must come before top-level pkgs

But this doesn't resolve all problems, currently some packages must be reordered manually.
mlell added a commit that referenced this issue May 30, 2021
@mlell
Reorder R dependencies to not install packages before their dependencies
b44204d 
Workaround for #2, but currently each time this list is regenerated
by scan_r_dependencies.R, the reordering is lost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mlell