don't crash when host ssh public keys are missing

Author: rrotter

manifests/profile/known_host_public_keys.pp

@@ -13,14 +13,16 @@
 # only trusts the hosts; it does not actually grant access through a
 # firewall or anything.
 class nebula::profile::known_host_public_keys {
-  $facts['ssh'].each |$name, $key_obj| {
-    $type = $key_obj["type"]
-    $key = $key_obj["key"]
+  if $facts['ssh'] != undef {
+    $facts['ssh'].each |$name, $key_obj| {
+      $type = $key_obj["type"]
+      $key = $key_obj["key"]
 
-    @@concat_fragment { "known host ${::networking['fqdn']} ${name}":
-      tag     => 'known_host_public_keys',
-      target  => '/etc/ssh/ssh_known_hosts',
-      content => "${::networking['fqdn']} ${type} ${key}\n",
+      @@concat_fragment { "known host ${::networking['fqdn']} ${name}":
+        tag     => 'known_host_public_keys',
+        target  => '/etc/ssh/ssh_known_hosts',
+        content => "${::networking['fqdn']} ${type} ${key}\n",
+      }
     }
   }
 }

spec/classes/profile/known_host_public_keys_spec.rb

@@ -30,8 +30,6 @@
           }
         end
 
-        it { is_expected.to compile }
-
         it "exports an ssh_known_hosts line for its ecdsa key" do
           expect(exported_resources).to contain_concat_fragment("known host example.invalid ecdsa")
             .with_target("/etc/ssh/ssh_known_hosts")
@@ -46,6 +44,19 @@
             .with_content("example.invalid ssh-rsa rsa_key\n")
         end
       end
+
+      context "with fqdn of example.invalid and some no ssh public keys" do
+        let(:facts) do
+          {
+            networking: {
+              ip: "0.1.2.3",
+              fqdn: "example.invalid"
+            },
+          }
+        end
+
+        it { is_expected.to compile }
+      end
     end
   end
 end