add class to replace resolv_conf module

replace saz/resolv_conf with internal nebula::resolv_conf

Author: rrotter

.fixtures.yml

@@ -39,5 +39,4 @@ fixtures:
     reboot:              {"repo": "puppetlabs/reboot",          "ref": "5.0.0" }
     sshkeys_core:        {"repo": "puppetlabs/sshkeys_core",    "ref": "2.4.0" }
     stdlib:              {"repo": "puppetlabs/stdlib",          "ref": "9.4.1" }
-    resolv_conf:         {"repo": "saz/resolv_conf",            "ref": "5.1.0" }
     debconf:             {"repo": "stm/debconf",                "ref": "6.0.0" }

manifests/profile/dns/smartconnect.pp

@@ -44,7 +44,7 @@
     $nameservers = $other_ns_ips
   }
 
-  class { 'resolv_conf':
+  class { 'nebula::resolv_conf':
     nameservers => concat(['127.0.0.1'], $nameservers),
     searchpath  => lookup('nebula::resolv_conf::searchpath'),
     require     => Service['bind9']

manifests/profile/dns/standard.pp

@@ -9,8 +9,5 @@
 # @example
 #   include nebula::profile::dns::standard
 class nebula::profile::dns::standard {
-  class { 'resolv_conf':
-    nameservers => lookup('nebula::resolv_conf::nameservers'),
-    searchpath  => lookup('nebula::resolv_conf::searchpath'),
-  }
+  include nebula::resolv_conf
 }

manifests/resolv_conf.pp

@@ -0,0 +1,17 @@
+class nebula::resolv_conf (
+  Array[String] $nameservers,
+  Array[String] $searchpath = "",
+  String        $mode = '0644',
+){
+  # replicate behavior of saz/resolv_conf for Debian based OS
+  package { 'resolvconf':
+    ensure => absent
+  }
+
+  file { '/etc/resolv.conf':
+    owner   => 'root',
+    group   => 'root',
+    mode    => $mode,
+    content => template("nebula/resolv_conf/resolv.conf.erb"),
+  }
+}

metadata.json

@@ -30,7 +30,6 @@
     {"name": "puppetlabs/reboot",          "version_requirement": ">= 5.0.0  < 6.0.0" },
     {"name": "puppetlabs/sshkeys_core",    "version_requirement": ">= 2.4.0  < 3.0.0" },
     {"name": "puppetlabs/stdlib",          "version_requirement": ">= 9.4.1  < 10.0.0"},
-    {"name": "saz/resolv_conf",            "version_requirement": ">= 5.1.0  < 6.0.0" },
     {"name": "stm/debconf",                "version_requirement": ">= 6.0.0  < 7.0.0" }
   ],
   "operatingsystem_support": [

spec/classes/profile/dns/smartconnect_spec.rb

@@ -21,7 +21,7 @@
       end
 
       it do
-        is_expected.to contain_class('resolv_conf').with_nameservers(
+        is_expected.to contain_class('nebula::resolv_conf').with_nameservers(
           [
             '127.0.0.1',  # localhost
             '5.5.5.5',    # nebula::resolv_conf::nameservers[0]
@@ -79,7 +79,7 @@
         let(:params) { { other_ns_ips: ['3.3.3.3', '2.2.2.2', '1.1.1.1'] } }
 
         it do
-          is_expected.to contain_class('resolv_conf').with_nameservers(
+          is_expected.to contain_class('nebula::resolv_conf').with_nameservers(
             [
               '127.0.0.1',
               '3.3.3.3',

spec/classes/profile/dns/standard_spec.rb

@@ -11,7 +11,7 @@
       let(:facts) { os_facts }
 
       it do
-        is_expected.to contain_class('resolv_conf').with_nameservers(
+        is_expected.to contain_class('nebula::resolv_conf').with_nameservers(
           ['5.5.5.5', '4.4.4.4'],
         ).with_searchpath(['searchpath.default.invalid'])
       end

templates/resolv_conf/resolv.conf.erb

@@ -0,0 +1,8 @@
+# Managed by puppet (nebula/resolv_conf/resolv.conf.erb)
+
+<% if [email protected]? -%>
+search <%= @searchpath.join(" ") %>
+<% end -%>
+<% @nameservers.each do |ns| -%>
+nameserver <%= ns %>
+<% end -%>