Fixed almost all lint errors

Author: thejhh

lib/bot.js

@@ -1,17 +1,16 @@
-/*global Buffer: false, clearInterval: false, clearTimeout: false, console: false, global: false, module: false, process: false, querystring: false, require: false, setInterval: false, setTimeout: false, util: false, __filename: false, __dirname: false */
+/*global Buffer: false, clearInterval: false, clearTimeout: false, console: false, global: false, exports: false, module: false, process: false, querystring: false, require: false, setInterval: false, setTimeout: false, util: false, __filename: false, __dirname: false */
 
-var irc = require('irc');
-var timers = require('timers');
+var irc = require('irc'),
+    timers = require('timers');
 
 function Bot(settings) {
   this.settings = settings;
-  console.log('Connecting to IRC server ' + settings.irc.host + ' with nick ' +
-      settings.irc.nick);
+  console.log('Connecting to IRC server ' + settings.irc.host + ' with nick ' + settings.irc.nick);
 
 
   this.irc = new irc.Client(settings.irc.host, settings.irc.nick, {
     channels: settings.irc.channels,
-    password: settings.irc.password,
+    password: settings.irc.password
   });
 
   this.modules = [];
@@ -47,21 +46,22 @@ function Bot(settings) {
 
 exports.Bot = Bot;
 
-Bot.prototype.onQueueInterval = function (module) {
-  if (this.queue[module].length > 0) {
-    var item = this.queue[module][0];
+Bot.prototype.onQueueInterval = function (mod) {
+  if (this.queue[mod].length > 0) {
+    var item = this.queue[mod][0];
     this.irc.say(item.to, item.message);
-    this.queue[module] = this.queue[module].slice(1);
+    this.queue[mod] = this.queue[mod].slice(1);
   }
 };
 
-Bot.prototype.onDigest = function (module) {
-  var self = this;
-  var interval = setInterval(function () {
-    if (self.queue[module].length > 0) {
-      var item = self.queue[module][0];
+Bot.prototype.onDigest = function (mod) {
+  var self = this,
+      item,
+      interval = setInterval(function () {
+    if (self.queue[mod].length > 0) {
+      item = self.queue[mod][0];
       self.irc.say(item.to, item.message);
-      self.queue[module] = self.queue[module].slice(1);
+      self.queue[mod] = self.queue[mod].slice(1);
     }
     else {
       clearInterval(interval);
@@ -71,81 +71,91 @@ Bot.prototype.onDigest = function (module) {
 
 Bot.prototype.onError = function(msg) {
   console.error('Error: %s: %s', msg.command, msg.args.join(' '));
-}
+};
 
 Bot.prototype.onMessage = function(from, to, msg) {
-  if (route = this.findRoute(msg)) {
-    var obj = this;
-    route.fun.apply(route.module, [from, msg, args, function(out) {
+  var route = this.findRoute(msg), 
+      obj = this;
+  if (route) {
+    route.fun.apply(route.module, [from, msg, msg.args, function(out) {
       obj.queue[route.moduleName].push({to: to, message: out});
     }]);
   }
-}
+};
 
 Bot.prototype.onPM = function(from, msg) {
-  if (route = this.findRoute(msg)) {
-    var obj = this;
-    route.fun.apply(route.module, [from, msg, args, function(out) {
+  var route = this.findRoute(msg),
+      obj = this;
+  if (route) {
+    route.fun.apply(route.module, [from, msg, msg.args, function(out) {
       obj.queue[route.moduleName].push({to: from, message: out});
     }]);
   }
-}
+};
 
-Bot.prototype.loadModules = function() {
-  var self = this;
+Bot.prototype.loadModules = function(){
+  var self = this,
+      mod,
+      settings,
+      i,
+      module_,
+      m,
+      interval;
 
-  for (module in this.settings.modules) {
-    var settings = this.settings.modules[module];
-    m = require('./modules/' + module).Module;
-    this.modules[module] = new m(settings);
+  for (mod in this.settings.modules) { if(this.settings.modules.hasOwnProperty(mod)) {
+    settings = this.settings.modules[mod];
+    m = require('./modules/' + mod).Module;
+    this.modules[mod] = new m(settings);
 
-    this.queue[module] = [];
+    this.queue[mod] = [];
 
     if (settings.__digest) {
       setInterval(
-        function (module) { self.onDigest(module); },
+        function (mod) { self.onDigest(mod); },
         settings.__digest,
-        module
+        mod
       );
     }
     else {
       setInterval(
-        function (module) { self.onQueueInterval(module) },
+        function (mod) { self.onQueueInterval(mod); },
         settings.__interval || this.settings.interval,
-        module
+        mod
       );
     }
 
-    for (var i in this.modules[module].intervals) {
-      interval = this.modules[module].intervals[i];
+    for (i in this.modules[mod].intervals) { if(this.modules[mod].intervals.hasOwnProperty(i)) {
+      interval = this.modules[mod].intervals[i];
 
-      var module_ = module;
-      this.intervals[module] = timers.setInterval(interval[0], interval[1], 
+      module_ = mod;
+      this.intervals[mod] = timers.setInterval(interval[0], interval[1], 
           function(output) {
             self.settings.irc.channels.forEach(function (channel) {
               self.queue[module_].push({to: channel, message: output});
             });
           });
-    }
-  }
-}
+    }}
+  }}
+};
 
 Bot.prototype.findRoute = function(msg) {
-  if (msg[0] == "!") {
+  var route, mod, key, i, args;
+  if (msg[0] === "!") {
     msg = msg.substr(1);
-    for (key in this.modules) {
-      module = this.modules[key];
-      for (i in module.routes) {
-        route = module.routes[i];
-        if (args = route[0].exec(msg)) {
+    for (key in this.modules) { if(this.modules.hasOwnProperty(key)){
+      mod = this.modules[key];
+      for (i in mod.routes) { if(mod.routes.hasOwnProperty(i)){
+        route = mod.routes[i];
+        args = route[0].exec(msg);
+        if (args) {
           return {
             fun: route[1],
-            module: module,
+            mod: mod,
             moduleName: key
           };
         }
-      }
-    }
+      }}
+    }}
   }
-}
+};
 

lib/modules/docs.js

@@ -1,17 +1,16 @@
-/*global Buffer: false, clearInterval: false, clearTimeout: false, console: false, global: false, module: false, process: false, querystring: false, require: false, setInterval: false, setTimeout: false, util: false, __filename: false, __dirname: false */
+/*global Buffer: false, clearInterval: false, clearTimeout: false, console: false, global: false, exports:false, module: false, process: false, querystring: false, require: false, setInterval: false, setTimeout: false, util: false, __filename: false, __dirname: false */
 
 function DocsModule(settings) {
   this.settings = settings;
   this.routes = [
     [/^doc link ([a-z_]+)(#([a-zA-Z]+))?( (v[0-9]+\.[0-9]+\.[0-9]+))?/, this.onLink]
-  ]
+  ];
 }
 
 exports.Module = DocsModule;
 
 DocsModule.prototype.onLink = function(from, command, args, callback) {
-  v = args[5] || 'latest';
-  anchor = (args[3]) ? ('#' + args[1] + '.' + args[3]) : '';
+  var v = args[5] || 'latest',
+      anchor = (args[3]) ? ('#' + args[1] + '.' + args[3]) : '';
   callback('http://nodejs.org/docs/' + v + '/api/' + args[1] + '.html' + anchor);
-}
-
+};

lib/modules/eval-jail.js

@@ -1,26 +1,26 @@
-var vm = require('vm');
+/*global Buffer: false, clearInterval: false, clearTimeout: false, console: false, global: false, exports: false, module: false, process: false, querystring: false, require: false, setInterval: false, setTimeout: false, util: false, __filename: false, __dirname: false, unescape:false */
 
-var code = unescape('%s');
+var vm = require('vm'),
+    code = unescape('%s'),
+    modules = {crypto: 1, events: 1, url: 1, assert: 1},
+    context = {
+      require: function (mod) {
+        if (mod in modules) {
+          return modules[mod];
+        }
+        throw new Error("Cannot find module '" + mod + "'");
+      },
+      setTimeout: setTimeout,
+      setInterval: setInterval,
+      clearTimeout: clearTimeout,
+      clearInterval: clearInterval,
+      console: console
+    },
+    mod;
 
-var modules = {crypto: 1, events: 1, url: 1, assert: 1};
-var context = {
-  require: function (module) {
-    if (module in modules) {
-      return modules[module];
-    }
-    throw new Error("Cannot find module '" + module + "'");
-  },
-  setTimeout: setTimeout,
-  setInterval: setInterval,
-  clearTimeout: clearTimeout,
-  clearInterval: clearInterval,
-  console: console
-};
-
-for (module in modules) {
-  modules[module] = require(module);
-  context[module] = modules[module];
-}
+for (mod in modules) { if(modules.hasOwnProperty(mod)) {
+  modules[mod] = require(mod);
+  context[mod] = modules[mod];
+}}
 
 console.log(vm.runInNewContext(code, context));
-

lib/modules/eval.js

@@ -1,3 +1,5 @@
+/*global Buffer: false, clearInterval: false, clearTimeout: false, console: false, global: false, exports: false, module: false, process: false, querystring: false, require: false, setInterval: false, setTimeout: false, __filename: false, __dirname: false, escape:false */
+
 var fs = require('fs'),
     util = require('util'),
     spawn = require('child_process').spawn;
@@ -8,22 +10,21 @@ function EvalModule(settings) {
   this.settings.timeout = this.settings.timeout || 5000;
   this.routes = [
     [/^eval (.+)/, this.onEval]
-  ]
+  ];
 }
 
 exports.Module = EvalModule;
 
 EvalModule.fileName = function (from) {
   return 'dmkbot-' + (new Date()).getTime().toString() + '-' +
     encodeURIComponent(from) + '-' + Math.random().toString() + '.js';
-}
+};
 
 EvalModule.prototype.onEval = function(from, command, args, callback) {
   // This function uses eval-jail.js script, puts code in it, copies it to
   // prefix directory (usually /tmp) and executes.
-  var self = this;
-
-  var code = args[1];
+  var self = this,
+      code = args[1];
   console.log(from + " requested evaluation of '" + code + "'");
   fs.readFile(__dirname + '/eval-jail.js', 'utf-8', function (err, data) {
     if (err) {
@@ -38,18 +39,16 @@ EvalModule.prototype.onEval = function(from, command, args, callback) {
         return callback('Something went terribly wrong (cannot write jail script)');
       }
 
-      var node = spawn('node', [fileName]);
-
-      var t = setTimeout(function () {
-        callback('Timeout.');
-        node.kill();
-      }, self.settings.timeout);
-
-      var splitter = function (data) {
-        data.toString().split("\n").filter(
-          function (d) { return d != ""; }).forEach(callback);
-        // data would be outputed with empty line at the end, so we filter it
-      };
+      var node = spawn('node', [fileName]),
+          t = setTimeout(function () {
+            callback('Timeout.');
+            node.kill();
+          }, self.settings.timeout),
+          splitter = function (data) {
+            data.toString().split("\n").filter(
+            function (d) { return d !== ""; }).forEach(callback);
+            // data would be outputed with empty line at the end, so we filter it
+          };
 
       node.stdout.on('data', splitter);
       if (self.settings.stderr) {
@@ -64,5 +63,4 @@ EvalModule.prototype.onEval = function(from, command, args, callback) {
       });
     });
   });
-}
-
+};