Allow multiple exclude schemas for pgkit/migra

[PhilipWee]

I think right now the --exclude flag for pgkit/migra only supports a single schema (Correct me if I'm wrong)

I'm happy to open a PR to allow excluding multiple schemas in the flag

I was also working on extending the original migra package here, but I think since you're already maintaining this package I was thinking it would be better to skip the double work and focus our efforts here

I can migrate over my existing feature updates from my migra package to your repo if you're cool with it too

[mmkal]

I'd definitely be interested in this! And yes --exclude only supports one schema right now.

However the migra code is a bit strange - it's currently a pretty faithful port of the python. I wanted to minimise the chance of regret/pain if the original ever got updated, but that's looking increasingly unliikely.

I think excluding multiple schemas would be a good first step into moving migra forward - it could require a bit of a refactor though (if I remember right, --exclude-schema -> exclude_schema on the migration options -> schemainspector.get_inspector(client, schema, exclude_schema), and the implementation of that is weird. So it's goes a few levels deep!

---

Unrelatedly I am debugging a migra test failure that was introduced by the latest main commit. It's working fine for me locally but if you have problems i'll be working on it iin #452.

[PhilipWee]

I actually fixed it on my python port by allowing all of the below, but I'm open to suggestions

--exclude-schema schema_a
--exclude_schema schema_b
--exclude-schemas schema_a schema_b
--exclude_schemas schema_a schema_b

(ok full disclosure I totally forgot and missed the inconsistent casing, but I did see your comment on the original repo)

[mmkal]

Let's just make it a string array in the CLI. It's using trpc-cli which will automatically map that to commander's variation option syntax.

Edit: if you start with this change then follow the type errors that it causes all the way down it should work out:

[PhilipWee]

Sounds good, I'll implement that once I work out some other kinks that are resulting from me running windows like a peasant

[PhilipWee]

On a side note, what version of postgres are you running your tests on? Because I need to make the tests cases for additional test cases, so I'm wondering whether to write the tests in format, since the way they create some select queries are different

Sample test failure:

  create or replace view "public"."v2" as
  SELECT
-   t.id,
-   t.category,
+   id,
+   category,
    'b'::e AS e
  FROM
    t;

[mmkal]

13 in CI, various versions tested locally. I plan to test a few other versions in CI too but not sure when I'll get to that.

[reteps]

Hi @PhilipWee are you still interested in porting your additional features to this library? Specifically, your work on comments would be super helpful.

[PhilipWee]

@reteps yeap I am! Once this particular one is added I dont mind adding the other stuff as well, anyway I already have the other fixes written in python so its not alot of effort required from me

I might not be the fastest though because I just started another startup but Ill get the job done eventually