Skip to content

Commit 7d8b5b9

Browse files
authored
compat vllm>=0.8 (#3574)
1 parent b599898 commit 7d8b5b9

File tree

7 files changed

+15
-11
lines changed

7 files changed

+15
-11
lines changed

docs/source/Customization/自定义数据集.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ Agent格式请参考[Agent文档](../Instruction/智能体的支持.md)。
161161
"ms_dataset_id": "xxx/xxx"
162162
},
163163
{
164-
"dataset_path": "<dataset_path>"
164+
"dataset_path": "<dataset_dir/dataset_path>"
165165
},
166166
{
167167
"ms_dataset_id": "<dataset_id>",

docs/source_en/Customization/Custom-dataset.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ You can refer to the ms-swift built-in [dataset_info.json](https://github.com/mo
169169
"ms_dataset_id": "xxx/xxx"
170170
},
171171
{
172-
"dataset_path": "<dataset_path>"
172+
"dataset_path": "<dataset_dir/dataset_path>"
173173
},
174174
{
175175
"ms_dataset_id": "<dataset_id>",

swift/llm/dataset/loader.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def get_dataset_meta(self, use_hf: bool):
9393
if dataset_type == 'path':
9494
dataset_meta = dataset_meta_mapping.get((dataset_type, self.dataset.lower()))
9595
else:
96-
dataset_type = {True: 'hf', False: 'ms'}[use_hf]
96+
dataset_type = 'repo' if os.path.isdir(self.dataset) else {True: 'hf', False: 'ms'}[use_hf]
9797
dataset_meta = dataset_meta_mapping.get((dataset_type, self.dataset.lower()))
9898
return dataset_meta or self._get_matched_dataset_meta(dataset_meta_mapping) or DatasetMeta()
9999

@@ -105,7 +105,8 @@ def _get_dataset_meta_mapping() -> Dict[Tuple[str, str], DatasetMeta]:
105105
_dataset_meta_mapping = {}
106106
for dataset_meta in DATASET_MAPPING.values():
107107
if dataset_meta.dataset_path is not None:
108-
_dataset_meta_mapping[('path', dataset_meta.dataset_path.lower())] = dataset_meta
108+
dataset_type = 'repo' if os.path.isdir(dataset_meta.dataset_path) else 'path'
109+
_dataset_meta_mapping[(dataset_type, dataset_meta.dataset_path.lower())] = dataset_meta
109110
if dataset_meta.ms_dataset_id is not None:
110111
_dataset_meta_mapping[('ms', dataset_meta.ms_dataset_id.lower())] = dataset_meta
111112
if dataset_meta.hf_dataset_id is not None:

swift/llm/infer/deploy.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,7 @@ def _compute_infer_stats(self):
5757
def lifespan(self, app: FastAPI):
5858
args = self.args
5959
if args.log_interval > 0:
60-
thread = Thread(target=lambda: asyncio.run(self._log_stats_hook()))
61-
thread.daemon = True
60+
thread = Thread(target=lambda: asyncio.run(self._log_stats_hook()), daemon=True)
6261
thread.start()
6362
try:
6463
yield

swift/llm/infer/infer_engine/pt_engine.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,7 @@ def _post_init(self):
9292

9393
def _start_infer_worker(self):
9494
if self._task_thread is None:
95-
self._task_thread = Thread(target=self._infer_worker)
96-
self._task_thread.daemon = True
95+
self._task_thread = Thread(target=self._infer_worker, daemon=True)
9796
self._task_thread.start()
9897

9998
def _fetch_infer_requests(self):

swift/llm/infer/infer_engine/vllm_engine.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,13 @@ async def _infer_full_async(
379379
return self._create_chat_completion_response(result, template, generation_config, request_id)
380380

381381
def _batch_infer_stream(self, *args, **kwargs):
382-
self.engine.engine.model_executor.parallel_worker_tasks = None
382+
if hasattr(self.engine, 'engine'):
383+
self.engine.engine.model_executor.parallel_worker_tasks = None
384+
elif hasattr(self.engine, 'engine_core'):
385+
# vllm>=0.8
386+
self.engine.engine_core.outputs_queue = None
387+
self.engine.engine_core.queue_task = None
388+
self.engine.output_handler = None
383389
return super()._batch_infer_stream(*args, **kwargs)
384390

385391
def infer(

swift/utils/io_utils.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@ def _append(self, obj: Union[Dict, List[Dict]], gather_obj: bool = False):
7676
def append(self, obj: Union[Dict, List[Dict]], gather_obj: bool = False):
7777
if self.enable_async:
7878
if self._thread is None:
79-
self._thread = Thread(target=self._append_worker)
80-
self._thread.daemon = True
79+
self._thread = Thread(target=self._append_worker, daemon=True)
8180
self._thread.start()
8281
self._queue.put({'obj': obj, 'gather_obj': gather_obj})
8382
else:

0 commit comments

Comments
 (0)