Skip to content

Commit 8b893bd

Browse files
committed
Hotfix: Corrupted data no longer saved to thread cache
1 parent efdc606 commit 8b893bd

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
66
This project mostly adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html);
77
however, insignificant breaking changes do not guarantee a major version bump, see the reasoning [here](https://github.com/kyb3r/modmail/issues/319). If you're a plugin developer, note the "BREAKING" section.
88

9+
# v3.8.3
10+
11+
This update is a quick hotfix for a weird behaviour experienced on 1 Feb 2021 where users were not properly cached.
12+
13+
### Fixed
14+
15+
- Corrupted data is no longer saved to thread cache.
16+
917
# v3.8.2
1018

1119
### Fixed

core/thread.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -1127,7 +1127,9 @@ async def find(
11271127
)
11281128
if channel:
11291129
thread = Thread(self, recipient or recipient_id, channel)
1130-
self.cache[recipient_id] = thread
1130+
if thread.recipient:
1131+
# only save if data is valid
1132+
self.cache[recipient_id] = thread
11311133
thread.ready = True
11321134
return thread
11331135

0 commit comments

Comments
 (0)