DeviceContainer: Use std::vector<Device*> instead std::map

Linear search is faster for smaller container sizes (below 10K).

Author: manup

device.cpp

@@ -943,11 +943,11 @@ std::vector<Resource *> Device::subDevices() const
 
 Device *DEV_GetDevice(DeviceContainer &devices, DeviceKey key)
 {
-    auto d = devices.find(key);
+    auto d = std::find_if(devices.begin(), devices.end(), [key](Device *device){ return device->key() == key; });
 
     if (d != devices.end())
     {
-        return d->second;
+        return *d;
     }
 
     return nullptr;
@@ -956,18 +956,17 @@ Device *DEV_GetDevice(DeviceContainer &devices, DeviceKey key)
 Device *DEV_GetOrCreateDevice(QObject *parent, DeviceContainer &devices, DeviceKey key)
 {
     Q_ASSERT(key != 0);
-    auto d = devices.find(key);
+    auto d = std::find_if(devices.begin(), devices.end(), [key](Device *device){ return device->key() == key; });
 
     if (d == devices.end())
     {
-        auto res = devices.insert({key, new Device(key, parent)});
-        d = res.first;
-        Q_ASSERT(d->second);
+        devices.push_back(new Device(key, parent));
+        return devices.back();
     }
 
     Q_ASSERT(d != devices.end());
 
-    return d->second;
+    return *d;
 }
 
 /*! Is used to test full Device control over: Device and sub-device creation, read, write, parse of Zigbee commands.

device.h

@@ -144,7 +144,7 @@ class Device : public QObject,
     bool m_managed = false; //! a managed device doesn't rely on legacy implementation of polling etc.
 };
 
-using DeviceContainer = std::unordered_map<DeviceKey, Device*>;
+using DeviceContainer = std::vector<Device*>;
 
 /*! Returns a device for a given \p key.
 

rest_devices.cpp

@@ -68,11 +68,11 @@ int RestDevices::getAllDevices(const ApiRequest &req, ApiResponse &rsp)
 
     rsp.httpStatus = HttpStatusOk;
 
-    for (const auto &d : plugin->m_devices)
+    for (const Device *d : plugin->m_devices)
     {
-        if (d.second->node()) // for now only physical devices
+        if (d) // for now only physical devices
         {
-            rsp.list.push_back(d.second->item(RAttrUniqueId)->toString());
+            rsp.list.push_back(d->item(RAttrUniqueId)->toString());
         }
     }