[External] [stdlib] [NFC] Rename List.bytecount() to byte_length() (#54664)

[External] [stdlib] [NFC] Rename `List.bytecount()` to `byte_length()`

Rename `List.bytecount()` to `byte_length()` to keep consistency with
all Stringlike types.

Co-authored-by: martinvuyk <[email protected]>
Co-authored-by: Joe Loser <[email protected]>
Closes #3897
MODULAR_ORIG_COMMIT_REV_ID: bcb5da166f0490eaea10f88a45cf9023e8bb8f63

Author: 2 people

docs/changelog.md

@@ -132,6 +132,9 @@ ctx.enqueue_function(compiled_func, grid_dim=1, block_dim=1)
   var val1 = warp.broadcast(x)
   ```
 
+- `List.bytecount()` has been renamed to `List.byte_length()` for consistency
+  with the String-like APIs.
+
 ### Tooling changes
 
 #### Mojo Compiler

stdlib/src/collections/list.mojo

@@ -467,11 +467,11 @@ struct List[T: CollectionElement, hint_trivial_type: Bool = False](
     # Methods
     # ===-------------------------------------------------------------------===#
 
-    fn bytecount(self) -> Int:
-        """Gets the bytecount of the List.
+    fn byte_length(self) -> Int:
+        """Gets the byte length of the List (`len(self) * sizeof[T]()`).
 
         Returns:
-            The bytecount of the List.
+            The byte length of the List (`len(self) * sizeof[T]()`).
         """
         return len(self) * sizeof[T]()
 

stdlib/test/collections/test_list.mojo

@@ -45,7 +45,7 @@ def test_list():
         list.append(i)
 
     assert_equal(5, len(list))
-    assert_equal(5 * sizeof[Int](), list.bytecount())
+    assert_equal(5 * sizeof[Int](), list.byte_length())
     assert_equal(0, list[0])
     assert_equal(1, list[1])
     assert_equal(2, list[2])