Skip to content
  • Sponsor modxcms/revolution

  • Notifications You must be signed in to change notification settings
  • Fork 529
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form customization - Template column acting weird #16719

Open
patrickatwsrn opened this issue Mar 12, 2025 · 1 comment
Open

Form customization - Template column acting weird #16719

patrickatwsrn opened this issue Mar 12, 2025 · 1 comment
Labels
bug The issue in the code or project, which should be addressed.

Comments

@patrickatwsrn
Copy link

Quick report about issues inside form customization:

I have three customizations inside a single customization setting:

Image

I've noticed, that the template column is sometimes acting in strange ways

If I use the reload button, I the grid displays the same value in every field.
Image

Sometimes the first field seems to be empty:

Image

If I double click the field, shows the right id (10).

Image

If I select a value from one of the available options it shows the right label

Image

But If I set the focus to another field, it is empty again.

As far as I can see, the right template id is always stored. Only the output inside the grid seems to be messed up.

Kind regards

Patrick

Environment

MODX 3.1.1

@patrickatwsrn patrickatwsrn added the bug The issue in the code or project, which should be addressed. label Mar 12, 2025
@smg6511
Copy link
Collaborator

smg6511 commented Mar 14, 2025

I address this in my open PR #16653 by removing the use of the Template dropdown editor field in the Sets grid; it's highly problematic, particularly when there are multiple instances and when the dropdown is multi-page. That fix is part of a very large PR that needs review, so ....

Anyway, this is what the solution looks like. It follows the other prevalent grids pattern of having the primary field formatted as a link to the next level of editing. (Note that my dev install has a bunch of orphaned records, which is why you see some rows with an "undefined" template.)

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

No branches or pull requests

2 participants