-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the labels. #79
Comments
@shubhamkarande13 I wonder if it should be assigned directly to @HarshCasper or not. Although, @HarshCasper can do it directly, and that may be more time efficient. Pro of a new comer being involved is that it may help them feel more involved and welcomed. Con is obviously that it may be time consuming. |
I would like to work on it @Chicken-Biryani Please assign it to me. |
Thanks @Chicken-Biryani @HarshCasper, is that would be okay ? |
Hey, I found this document while digging up. |
Hey, @raghavraj-27 that's really cool. Great job! Gives us a good lead. However, what I am concerned about:
So we just need to think about the labels we want and don't want. We could first have a look at the labels that are getting used in the community website and FLINT. . Let's keep the extra labels on hold for now, and discuss them with @HarshCasper and @shubhamkarande13 later. |
Hi @raghavraj-27 @Chicken-Biryani The purpose of this issue is to make sure that our GitHub issue labelling process is consistent. Right now, we follow vastly different issue label configurations on different projects (take for an example community website and/or FLINT). Since we have so many repositories, we should come up with a reasonable set of standard labels that are suitable for our needs. The trick will be not to have TOO many labels. I also found some good links:
We should make some decisions on if we want to use emoji in Labels and how non-Label tags might be used (in particular, Milestones and Projects) Once decided, we can simply add all of those labels in the respective repos using this script (some dummy data is being used to show the purpose): [
{
"name": "Type: Help Needed",
"color": "5319e7"
},
{
"name": "Priority: Critical",
"color": "ff2222"
},
{
"name": "Priority: High",
"color": "FF7922"
},
{
"name": "Priority: Low",
"color": "c2e0c6"
},
{
"name": "Priority: Medium",
"color": "fbca04"
},
{
"name": "Status: Complete",
"color": "7ED321"
},
{
"name": "Status: Confirmed",
"color": "0e8a16"
},
{
"name": "Status: Feedback Needed",
"color": "006b75"
},
{
"name": "Status: In Progress",
"color": "FC8264"
},
{
"name": "Status: On Hold",
"color": "BABABA"
},
{
"name": "Status: Review Needed",
"color": "EAE435"
},
{
"name": "Type: Bug",
"color": "ff2222"
},
{
"name": "Type: Enhancement",
"color": "1d76db"
},
{
"name": "Type: Feature",
"color": "6DFF6D"
},
{
"name": "Type: Idea",
"color": "6DE6FF"
},
{
"name": "Type: Question",
"color": "FF6DD9"
}
].forEach(function(label) {
addLabel(label)
})
function updateLabel (label) {
var flag = false;
[].slice.call(document.querySelectorAll(".labels-list-item"))
.forEach(function(element) {
if (element.querySelector('.label-link').textContent.trim() === label.name) {
flag = true
element.querySelector('.js-edit-label').click()
element.querySelector('.js-new-label-name-input').value = label.name
element.querySelector('.js-new-label-color-input').value = '#' + label.color
element.querySelector('.js-edit-label-cancel ~ .btn-primary').click()
}
})
return flag
}
function addNewLabel (label) {
document.querySelector('.js-new-label-name-input').value = label.name
document.querySelector('.js-new-label-color-input').value = '#' + label.color
document.querySelector('.js-details-target ~ .btn-primary').disabled = false
document.querySelector('.js-details-target ~ .btn-primary').click()
}
function addLabel (label) {
if (!updateLabel(label)) addNewLabel(label)
} Tagging @aornugent @shubhamkarande13 @sarthakkundra to understand what their opinion would be. |
As of now for this particular repo, I have prepared this doc as said in the issue and tried to put a satisfying description for each label. |
I like this @raghavraj-27. Generally fewer labels is better. Maybe we don't need the 'assigned' label (instead use Github assignment) or the time estimate labels (T=1 etc)? Please also reconcile with: https://github.com/moja-global/About_moja_global/labels and https://github.com/moja-global/FLINT/labels |
Hey, @raghavraj-27 you've done a great job. Must have taken a lot of effort. Thank you for putting in the time. Here's a suggestion - Maybe, you could add more columns.
For example:
In the example :
|
Thanks @aornugent and @Chicken-Biryani for the review. One thing I am observing that some labels like let say Here is the doc link -> https://docs.google.com/document/d/19KBNLnTdr3xCWE60z_5b8iVNpNRaa8S67YRR96pCw8g/edit?usp=sharing Please review once again. |
Describe how we are communicating and why it is not optimal.
The labels haven't been described properly. A new contributor may have difficulty understanding what a particular label means.
Describe the solution you'd like.
A volunteer could coordinate with @HarshCasper and create a table with contents:
Label Name | Description | Colour
Fill it up and then someone from the docs team can edit the labels.
Describe alternatives you've considered.
--
Additional context.
Open to suggestions or better ways to complete the label's description.
The text was updated successfully, but these errors were encountered: