chore: fix phpstan

Author: Naoray

examples/captures/create-capture.php

@@ -4,7 +4,6 @@
  * How to prepare a new payment with the Mollie API.
  */
 
-use Mollie\Api\Http\Data\CreatePaymentCapturePayload;
 use Mollie\Api\Http\Data\Money;
 use Mollie\Api\Http\Requests\CreatePaymentCaptureRequest;
 
@@ -22,10 +21,11 @@
      *   description   Description of the capture.
      *   metadata      Custom metadata that is stored with the payment.
      */
-    $response = $mollie->send(new CreatePaymentCaptureRequest('tr_WDqYK6vllg', new CreatePaymentCapturePayload(
+    $response = $mollie->send(new CreatePaymentCaptureRequest(
+        'tr_WDqYK6vllg',
         'Order #12345',
         new Money('EUR', '5.00')
-    )));
+    ));
 
     $capture = $response->toResource();
 

examples/client-links/create-client-link.php

@@ -3,7 +3,6 @@
 /*
  * How to create a new client link in the Mollie API.
  */
-
 use Mollie\Api\Http\Data\CreateClientLinkPayload;
 use Mollie\Api\Http\Data\Owner;
 use Mollie\Api\Http\Data\OwnerAddress;
@@ -29,13 +28,13 @@
      */
     $response = $mollie
         ->send(
-            new CreateClientLinkRequest(new CreateClientLinkPayload(
+            new CreateClientLinkRequest(
                 new Owner('[email protected]', 'foo', 'bar', 'nl_NL'),
                 'Foo Company',
                 new OwnerAddress('NL', 'Keizersgracht 313', '1016 EE', 'Amsterdam'),
                 '30204462',
                 'NL123456789B01',
-            ))
+            )
         );
 
     $clientLink = $response->toResource();

examples/customers/create-customer-first-payment.php

@@ -4,12 +4,10 @@
  * How to create a first payment to allow recurring payments later.
  */
 
-use Mollie\Api\Factories\CreatePaymentRequestFactory;
 use Mollie\Api\Http\Data\Metadata;
 use Mollie\Api\Http\Data\Money;
 use Mollie\Api\Http\Requests\CreateCustomerPaymentRequest;
 use Mollie\Api\Http\Requests\GetPaginatedCustomerRequest;
-use Mollie\Api\Types\SequenceType;
 
 try {
     /*
@@ -40,19 +38,17 @@
      *
      * @See: https://docs.mollie.com/reference/v2/customers-api/create-customer-payment
      */
-    $payload = CreatePaymentRequestFactory::new([
-        'description' => "First payment - Order #{$orderId}",
-        'amount' => new Money('EUR', '10.00'),
-        'redirectUrl' => "{$protocol}://{$hostname}/payments/return.php?order_id={$orderId}",
-        'webhookUrl' => "{$protocol}://{$hostname}/payments/webhook.php",
-        'metadata' => new Metadata([
-            'order_id' => $orderId,
-        ]),
-        'sequenceType' => SequenceType::FIRST,
-    ])->create();
-
     $payment = $mollie->send(
-        new CreateCustomerPaymentRequest($customer->id, $payload)
+        new CreateCustomerPaymentRequest(
+            $customer->id,
+            "First payment - Order #{$orderId}",
+            new Money('EUR', '10.00'),
+            "{$protocol}://{$hostname}/payments/return.php?order_id={$orderId}",
+            "{$protocol}://{$hostname}/payments/webhook.php",
+            new Metadata([
+                'order_id' => $orderId,
+            ])
+        )
     );
 
     /*

phpstan-baseline.neon

@@ -270,6 +270,12 @@ parameters:
 			count: 1
 			path: examples/subscriptions/update-subscription.php
 
+		-
+			message: '#^Unsafe usage of new static\(\)\.$#'
+			identifier: new.static
+			count: 1
+			path: src/Factories/Factory.php
+
 		-
 			message: '#^Unsafe usage of new static\(\)\.$#'
 			identifier: new.static

src/Contracts/Connector.php

@@ -7,7 +7,10 @@
 
 interface Connector extends Authenticatable, IdempotencyContract, SupportsDebuggingContract, Testable
 {
-    public function send(Request $request): ?object;
+    /**
+     * @return mixed
+     */
+    public function send(Request $request);
 
     public function resolveBaseUrl(): string;
 

src/EndpointCollection/InvoiceEndpointCollection.php

@@ -61,7 +61,6 @@ public function iterator(?string $from = null, ?int $limit = null, array $filter
             ])
             ->create();
 
-        /** @var InvoiceCollection */
         return $this->send(
             $request
                 ->useIterator()

src/EndpointCollection/PaymentRefundEndpointCollection.php

@@ -35,7 +35,7 @@ public function createFor(Payment $payment, array $data, $testmode = false): Ref
      */
     public function createForId(string $paymentId, array $payload = [], $testmode = false): Refund
     {
-        $testmode = Utility::extractBool($payload, 'testmode', false) ??
+        $testmode = Utility::extractBool($payload, 'testmode', false) ?:
             Utility::extractBool($testmode, 'testmode', false);
 
         $request = CreatePaymentRefundRequestFactory::new($paymentId)

src/EndpointCollection/SessionEndpointCollection.php

@@ -4,7 +4,6 @@
 
 use Mollie\Api\Exceptions\RequestException;
 use Mollie\Api\Factories\SortablePaginatedQueryFactory;
-use Mollie\Api\Http\Data\AnyData;
 use Mollie\Api\Http\Requests\CancelSessionRequest;
 use Mollie\Api\Http\Requests\CreateSessionRequest;
 use Mollie\Api\Http\Requests\GetPaginatedSessionsRequest;
@@ -53,11 +52,11 @@ public function create(array $payload = [], array $query = []): Session
      *
      * Will throw a ApiException if the session id is invalid or the resource cannot be found.
      *
-     * @param  array|AnyData  $payload
+     * @param  array  $payload
      *
      * @throws RequestException
      */
-    public function update(string $id, $payload = []): Session
+    public function update(string $id, array $payload = []): Session
     {
         $request = new UpdateSessionRequest($id);
 

src/Factories/CreateCustomerPaymentRequestFactory.php

@@ -50,7 +50,7 @@ public function create(): CreateCustomerPaymentRequest
             $this->payload('sequenceType'),
             $this->payload('mandateId'),
             $this->payload('profileId'),
-            $this->payload('additional') ?? Utility::filterByProperties(CreateCustomerPaymentRequest::class, $this->payload()) ?? [],
+            $this->payload('additional') ?: Utility::filterByProperties(CreateCustomerPaymentRequest::class, $this->payload()) ?: [],
             $this->query('includeQrCode', false)
         );
     }

src/Factories/CreatePaymentRequestFactory.php

@@ -43,7 +43,7 @@ public function create(): CreatePaymentRequest
             $this->payload('mandateId'),
             $this->payload('customerId'),
             $this->payload('profileId'),
-            $this->payload('additional') ?? Utility::filterByProperties(CreatePaymentRequest::class, $this->payload()) ?? [],
+            $this->payload('additional') ?: Utility::filterByProperties(CreatePaymentRequest::class, $this->payload()) ?: [],
             $this->query('includeQrCode', false)
         );
     }